libexif-devel

[Libexif-devel] Re: [libexif-cvs] libexif/libexif exif-data.c,1.77,1.78 exif-tag.c,1.24,1.25 exif-tag.h,1.12,1.13

[Hans U. N. <gp...@n-...>]

Lutz M=C3=BCller <lu...@us...> writes:

> Index: exif-tag.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/libexif/libexif/libexif/exif-tag.c,v
> retrieving revision 1.24
> retrieving revision 1.25
> diff -u -p -d -r1.24 -r1.25
> --- exif-tag.c	24 Apr 2005 19:01:12 -0000	1.24
> +++ exif-tag.c	26 Apr 2005 20:17:46 -0000	1.25
> @@ -30,7 +30,8 @@ typedef enum {
>  	ESL_MANDATORY    =3D 1, /* Mandatory               */
>  	ESL_CMANDATORY   =3D 2, /* Conditionally mandatory */
>  	ESL_OPTIONAL     =3D 3, /* Optional                */
> -	ESL_NOT_RECORDED =3D 4  /* Not recorded            */
> +	ESL_COPTIONAL    =3D 5, /* Conditionally optional  */
> +	ESL_NOT_RECORDED =3D 6  /* Not recorded            */
>  } ExifSL;                     /* Exif Support Level      */

Who defines these constants? I'm just asking because this breaks
binary compatibility. (ESL_NOT_RECORDED now 6 instead of 4, and 4 is
not used any more).

Uli

Re: [Libexif-devel] Re: [libexif-cvs] libexif/libexif exif-data.c,1.77,1.78 exif-tag.c,1.24,1.25 exif-tag.h,1.12,1.13

[Hans U. N. <gp...@n-...>]

Hans Ulrich Niedermann <gp...@n-...> writes:

> Lutz M=C3=BCller <lu...@us...> writes:
>
>> Index: exif-tag.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> RCS file: /cvsroot/libexif/libexif/libexif/exif-tag.c,v
>> retrieving revision 1.24
>> retrieving revision 1.25
>> diff -u -p -d -r1.24 -r1.25
>> --- exif-tag.c	24 Apr 2005 19:01:12 -0000	1.24
>> +++ exif-tag.c	26 Apr 2005 20:17:46 -0000	1.25
>> @@ -30,7 +30,8 @@ typedef enum {
>>  	ESL_MANDATORY    =3D 1, /* Mandatory               */
>>  	ESL_CMANDATORY   =3D 2, /* Conditionally mandatory */
>>  	ESL_OPTIONAL     =3D 3, /* Optional                */
>> -	ESL_NOT_RECORDED =3D 4  /* Not recorded            */
>> +	ESL_COPTIONAL    =3D 5, /* Conditionally optional  */
>> +	ESL_NOT_RECORDED =3D 6  /* Not recorded            */
>>  } ExifSL;                     /* Exif Support Level      */
>
> Who defines these constants?

That is meant as in "us or the EXIF specs?"

> I'm just asking because this breaks
> binary compatibility. (ESL_NOT_RECORDED now 6 instead of 4, and 4 is
> not used any more).

Re: [Libexif-devel] Re: [libexif-cvs] libexif/libexif exif-data.c,1.77,1.78 exif-tag.c,1.24,1.25 exif-tag.h,1.12,1.13

[Lutz <lu...@us...>]

On Wed, 2005-04-27 at 17:09 +0200, Hans Ulrich Niedermann wrote:
> > Who defines these constants?
>=20
> That is meant as in "us or the EXIF specs?"

EXIF spec. Some tags must/can be present in EXIF data, others must not
be present in some IFDs, others must/can be present if certain
conditions are met.

> > I'm just asking because this breaks
> > binary compatibility. (ESL_NOT_RECORDED now 6 instead of 4, and 4 is
> > not used any more).

Why does the change break binary compatibility? The values are defined
and used only inside exif-tag.c.
--=20
Lutz M=FCller <lu...@us...>

Re: [Libexif-devel] Re: [libexif-cvs] libexif/libexif exif-data.c,1.77,1.78 exif-tag.c,1.24,1.25 exif-tag.h,1.12,1.13

[Hans U. N. <gp...@n-...>]

Lutz M=C3=BCller <lu...@us...> writes:

> On Wed, 2005-04-27 at 17:09 +0200, Hans Ulrich Niedermann wrote:
>> > Who defines these constants?
>>=20
>> That is meant as in "us or the EXIF specs?"
>
> EXIF spec. Some tags must/can be present in EXIF data, others must not
> be present in some IFDs, others must/can be present if certain
> conditions are met.

OK, of course the EXIF specs define what tags are optional, but it is
*us* who defines the values of the ESL_* constants.

>> > I'm just asking because this breaks
>> > binary compatibility. (ESL_NOT_RECORDED now 6 instead of 4, and 4 is
>> > not used any more).
>
> Why does the change break binary compatibility? The values are defined
> and used only inside exif-tag.c.

I guess then it is not a problem.

I suppose then there is no specific reason to use 1,2,3,5,6, leaving
out the 4, either.

Uli

Re: [Libexif-devel] Re: [libexif-cvs] libexif/libexifexif-data.c, 1.77,1.78 exif-tag.c,1.24,1.25 exif-tag.h,1.12,1.13

[Lutz <lu...@us...>]

> I suppose then there is no specific reason to use 1,2,3,5,6, leaving
> out the 4, either.

Right.

Lutz