You can subscribe to this list here.
2002 |
Jan
|
Feb
|
Mar
|
Apr
(6) |
May
|
Jun
(5) |
Jul
(17) |
Aug
(4) |
Sep
(5) |
Oct
(5) |
Nov
(26) |
Dec
(6) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2003 |
Jan
(8) |
Feb
|
Mar
(3) |
Apr
(3) |
May
|
Jun
|
Jul
(4) |
Aug
(18) |
Sep
(9) |
Oct
(8) |
Nov
(5) |
Dec
(4) |
2004 |
Jan
(10) |
Feb
(1) |
Mar
(7) |
Apr
(11) |
May
(13) |
Jun
(5) |
Jul
(3) |
Aug
|
Sep
|
Oct
(15) |
Nov
(6) |
Dec
(10) |
2005 |
Jan
(1) |
Feb
(1) |
Mar
(25) |
Apr
(24) |
May
(9) |
Jun
(20) |
Jul
(13) |
Aug
(4) |
Sep
(17) |
Oct
(7) |
Nov
(2) |
Dec
(11) |
2006 |
Jan
(30) |
Feb
(12) |
Mar
(12) |
Apr
(12) |
May
(7) |
Jun
(12) |
Jul
(14) |
Aug
(16) |
Sep
(20) |
Oct
(16) |
Nov
(35) |
Dec
(42) |
2007 |
Jan
(34) |
Feb
(34) |
Mar
(29) |
Apr
(116) |
May
(42) |
Jun
(25) |
Jul
(4) |
Aug
(9) |
Sep
|
Oct
(2) |
Nov
(4) |
Dec
(10) |
2008 |
Jan
(9) |
Feb
(7) |
Mar
(2) |
Apr
(5) |
May
(2) |
Jun
(3) |
Jul
(3) |
Aug
|
Sep
(7) |
Oct
(4) |
Nov
(42) |
Dec
(20) |
2009 |
Jan
(12) |
Feb
(12) |
Mar
(1) |
Apr
(4) |
May
(2) |
Jun
(4) |
Jul
|
Aug
(3) |
Sep
(23) |
Oct
(34) |
Nov
(16) |
Dec
(8) |
2010 |
Jan
(5) |
Feb
(9) |
Mar
(3) |
Apr
(5) |
May
|
Jun
(1) |
Jul
|
Aug
|
Sep
|
Oct
(3) |
Nov
|
Dec
(14) |
2011 |
Jan
(4) |
Feb
|
Mar
(3) |
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
(2) |
Sep
(1) |
Oct
(1) |
Nov
(6) |
Dec
(4) |
2012 |
Jan
(2) |
Feb
|
Mar
(2) |
Apr
(10) |
May
(11) |
Jun
|
Jul
(21) |
Aug
(7) |
Sep
|
Oct
(1) |
Nov
(4) |
Dec
|
2013 |
Jan
(1) |
Feb
(6) |
Mar
(11) |
Apr
(2) |
May
|
Jun
|
Jul
(2) |
Aug
|
Sep
(4) |
Oct
|
Nov
(3) |
Dec
(7) |
2014 |
Jan
(1) |
Feb
|
Mar
(1) |
Apr
(8) |
May
(1) |
Jun
(6) |
Jul
(2) |
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
2015 |
Jan
(1) |
Feb
|
Mar
|
Apr
(1) |
May
|
Jun
(1) |
Jul
(1) |
Aug
(2) |
Sep
(1) |
Oct
(1) |
Nov
|
Dec
|
2016 |
Jan
|
Feb
|
Mar
(1) |
Apr
(2) |
May
(2) |
Jun
(3) |
Jul
|
Aug
|
Sep
(8) |
Oct
|
Nov
|
Dec
(1) |
2017 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
(5) |
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
(1) |
2018 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(1) |
Jun
|
Jul
|
Aug
(3) |
Sep
|
Oct
|
Nov
(1) |
Dec
|
2019 |
Jan
|
Feb
|
Mar
|
Apr
(1) |
May
(1) |
Jun
|
Jul
|
Aug
|
Sep
(1) |
Oct
(1) |
Nov
|
Dec
|
2020 |
Jan
(1) |
Feb
|
Mar
(1) |
Apr
(1) |
May
(14) |
Jun
(8) |
Jul
(3) |
Aug
(1) |
Sep
(1) |
Oct
(2) |
Nov
(1) |
Dec
|
2021 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
(4) |
Oct
(1) |
Nov
(5) |
Dec
(5) |
2022 |
Jan
(3) |
Feb
(2) |
Mar
|
Apr
(2) |
May
(1) |
Jun
|
Jul
(1) |
Aug
|
Sep
|
Oct
(1) |
Nov
|
Dec
|
2023 |
Jan
(1) |
Feb
|
Mar
(1) |
Apr
(1) |
May
|
Jun
|
Jul
(2) |
Aug
|
Sep
(1) |
Oct
|
Nov
|
Dec
(1) |
2024 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(2) |
Nov
|
Dec
|
From: Dan F. <da...@co...> - 2008-11-05 00:25:10
|
There are two entries in the libexif/contribs directory: a Python wrapper and a Watcom makefile. Both no longer work due to changes to libexif. Neither of them were in the 0.6.16 release, so I guess it's not a big deal if they're not in the imminent release, but is someone willing to fix them up for next time? >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Dan F. <da...@co...> - 2008-11-04 20:59:55
|
On Tue, Nov 04, 2008 at 08:59:16PM +0100, Lutz Müller wrote: > On Mon, 2008-11-03 at 14:48 -0800, Dan Fandrich wrote: > > Much as I'd like to help, of the two of us, you're the only project > > admin :-> > > No longer. That's what you get when you open your mouth :-} I think I can figure out what to do in SF, so I'll create some candidate tar balls for libexif & exif shortly and let everybody here take a look before making them official. Since this is really just a point release, I'll call it 0.6.17. I haven't looked at libexif-gtk and gexif yet, but since they're not tied tightly to a new libexif release, I think they can wait until afterward. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Marcus M. <ma...@je...> - 2008-11-04 17:01:27
|
On Tue, Nov 04, 2008 at 05:29:31PM +0100, Marcus Meissner wrote: > On Mon, Nov 03, 2008 at 07:20:57PM -0800, Dan Fandrich wrote: > > On Mon, Nov 03, 2008 at 09:52:16PM +0100, Marcus Meissner wrote: > > > Only if you changed an exported interface. I think there wasn't one. > > > > That makes it much easier. The "REVISION" field should be bumped, though. > > > > > Sync from the translation project before releasing: > > > > > > rsync -Lrtvz translationproject.org::tp/latest/libexif/ po > > > > I took a look at the translations and it looks like they're all up to date. > > However, a number of the translations are not in sync with > > translationproject.org because they were edited in the libexif CVS! This > > is a big no-no now (as described in the README file). Any local changes > > will be overwritten the next time a Translation Project volunteer updates > > a libexif translation. All changes must now be made through TP, except for > > the ru and en_CA domains, which are the only ones handled exclusively through > > libexif's CVS. > > > > These PO files all have local changes: > > > > cs.po > > de.po I now submitted de.po to translation project. There were around 4 strings or so changed judging from the diff I have. > > es.po > > fr.po > > ru.po > > sv.po Ciao, Marcus |
From: Marcus M. <ma...@je...> - 2008-11-04 16:51:18
|
On Mon, Nov 03, 2008 at 07:20:57PM -0800, Dan Fandrich wrote: > On Mon, Nov 03, 2008 at 09:52:16PM +0100, Marcus Meissner wrote: > > Only if you changed an exported interface. I think there wasn't one. > > That makes it much easier. The "REVISION" field should be bumped, though. > > > Sync from the translation project before releasing: > > > > rsync -Lrtvz translationproject.org::tp/latest/libexif/ po > > I took a look at the translations and it looks like they're all up to date. > However, a number of the translations are not in sync with > translationproject.org because they were edited in the libexif CVS! This > is a big no-no now (as described in the README file). Any local changes > will be overwritten the next time a Translation Project volunteer updates > a libexif translation. All changes must now be made through TP, except for > the ru and en_CA domains, which are the only ones handled exclusively through > libexif's CVS. > > These PO files all have local changes: > > cs.po > de.po > es.po > fr.po > ru.po > sv.po Ok, what I found out during libgphoto2 <-> translation project communication: - NEVER EVER RUN "make update-po". (I think for local translations this can be done, but not for externals.) - If you did "make dist", the POT file was regenerated and included into the tarball. You should commit the POT file at this time, but the update language.po files should probably be reverted. - Once the translation project has synced the release: -> fetch the language.po files from the translation project -> commit them. This way you will get only diffs from the translation project. Local translated languages can of course run make update-po , but should just commit their PO file, nothing else. Ciao, Marcus |
From: Stanislav B. <sb...@su...> - 2008-11-04 12:53:12
|
Dan Fandrich wrote: > It's been almost a year and a half since the last libexif release. In that > time there have been lots of bug fixes, more tag support, more translations > added, some serious security fixes and even a showstopper bug that causes > the GIMP to crash. I can't think of any reason not to make a new release > now. The SONAME hasn't even been bumped (should it be?) so the new > version should be a drop-in replacement for people. > > Is there anything holding back a release now? It would be nice to release libexif-gtk and gexif compatible with the current version of libexif and gtk+. Patches are pending in the bug tracker. -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sb...@su... Lihovarská 1060/12 tel: +420 284 028 966, +49 911 740538747 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ |
From: Dan F. <da...@co...> - 2008-11-04 03:21:13
|
On Mon, Nov 03, 2008 at 09:52:16PM +0100, Marcus Meissner wrote: > Only if you changed an exported interface. I think there wasn't one. That makes it much easier. The "REVISION" field should be bumped, though. > Sync from the translation project before releasing: > > rsync -Lrtvz translationproject.org::tp/latest/libexif/ po I took a look at the translations and it looks like they're all up to date. However, a number of the translations are not in sync with translationproject.org because they were edited in the libexif CVS! This is a big no-no now (as described in the README file). Any local changes will be overwritten the next time a Translation Project volunteer updates a libexif translation. All changes must now be made through TP, except for the ru and en_CA domains, which are the only ones handled exclusively through libexif's CVS. These PO files all have local changes: cs.po de.po es.po fr.po ru.po sv.po >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Dan F. <da...@co...> - 2008-11-03 22:48:13
|
On Mon, Nov 03, 2008 at 11:03:42PM +0100, Lutz Müller wrote: > I know just one reason: We are missing someone to do it :-) Go ahead. Much as I'd like to help, of the two of us, you're the only project admin :-> >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Marcus M. <ma...@je...> - 2008-11-03 20:52:32
|
On Mon, Nov 03, 2008 at 12:10:40PM -0800, Dan Fandrich wrote: > It's been almost a year and a half since the last libexif release. In that > time there have been lots of bug fixes, more tag support, more translations > added, some serious security fixes and even a showstopper bug that causes > the GIMP to crash. I can't think of any reason not to make a new release > now. The SONAME hasn't even been bumped (should it be?) so the new > version should be a drop-in replacement for people. Only if you changed an exported interface. I think there wasn't one. > Is there anything holding back a release now? Sync from the translation project before releasing: rsync -Lrtvz translationproject.org::tp/latest/libexif/ po Ciao, Marcus |
From: Dan F. <da...@co...> - 2008-11-03 20:47:10
|
It's been almost a year and a half since the last libexif release. In that time there have been lots of bug fixes, more tag support, more translations added, some serious security fixes and even a showstopper bug that causes the GIMP to crash. I can't think of any reason not to make a new release now. The SONAME hasn't even been bumped (should it be?) so the new version should be a drop-in replacement for people. Is there anything holding back a release now? >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Marcus M. <ma...@je...> - 2008-10-05 08:29:08
|
On Sun, Oct 05, 2008 at 09:54:30AM +0200, Jan Patera wrote: > > On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: > >> Please find a patch attached to this mail that solves a couple of > >> memory-corruption issues, and a couple of 64-bit mode options. > > > > Would you mind resending the patch in unified diff format (-u)? It's > > more reliable to apply and to review that way. > > > >>>> Dan > > Dan, It has been resent and then applied by Marcus. I have done few changes > since then. I don't know why, but I didn't receive any CVS > mails for Marcus' and my changes. Did anybody receive them? I got some python errors on commit. I think the CVS move might have broken the mail script :/ Ciao, Marcus |
From: Jan P. <pa...@pi...> - 2008-10-05 08:26:27
|
Niek, > The "unsigned int" -> "size_t" type changes are 64-bit fixes; when not > using these, one gets offsets in the > 2^31 range at times. ... > An additional set of changes within the maker-note files are to > prevent crashing on sizes > 64kb; It seems that the maker-notes, at > times, return sizes that are huge (as in: way beyond 2^31 bytes). Doesn't sound possible, unless there is a bug somewhere or the JPEG file is corrupted. Can you please send me some JPEG file where you get sizes over 2^31? Thanks. -- Jan |
From: Jan P. <pa...@pi...> - 2008-10-05 08:22:14
|
> On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: >> Please find a patch attached to this mail that solves a couple of >> memory-corruption issues, and a couple of 64-bit mode options. > > Would you mind resending the patch in unified diff format (-u)? It's > more reliable to apply and to review that way. > >>>> Dan Dan, It has been resent and then applied by Marcus. I have done few changes since then. I don't know why, but I didn't receive any CVS mails for Marcus' and my changes. Did anybody receive them? -- Jan |
From: Marcus M. <ma...@je...> - 2008-10-02 06:17:14
|
On Fri, Sep 26, 2008 at 03:54:59PM +0200, Niek Bergboer wrote: > Hi Marcus, > > Sure thing. Here is the new version of the patch. I have applied it as-is, but changed // to regular C comments before to be consistent with the rest of the codebase. Thanks! Ciao, Marcus |
From: Niek B. <ni...@go...> - 2008-09-26 13:55:22
|
Hi Marcus, Sure thing. Here is the new version of the patch. Regards, Niek Bergboer Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1 On Fri, Sep 26, 2008 at 3:18 PM, Marcus Meissner <ma...@je...> wrote: > On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: >> Hi developers, >> >> Please find a patch attached to this mail that solves a couple of >> memory-corruption issues, and a couple of 64-bit mode options. >> >> The "unsigned int" -> "size_t" type changes are 64-bit fixes; when not >> using these, one gets offsets in the > 2^31 range at times. >> >> The changes to exif-data.c prevent reading from e->data when e->data >> is NULL, and to prevent calling exif_data_save_data_entry if >> ifd->entries[j] is NULL. >> >> An additional set of changes within the maker-note files are to >> prevent crashing on sizes > 64kb; It seems that the maker-notes, at >> times, return sizes that are huge (as in: way beyond 2^31 bytes). >> According to the documentation, though, the full size of the EXIF data >> should fit within a JPEG section, thus intrinsically limiting it to 64 >> kb. I.e.: any s that is > 64 kb indicates a problem within the data. > > Is this diff the right way round? It seems you diffed new -> old > instead of old -> new > > Also please use diff -u > > Ciao, Marcus > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > libexif-devel mailing list > lib...@li... > https://lists.sourceforge.net/lists/listinfo/libexif-devel > |
From: Marcus M. <ma...@je...> - 2008-09-26 13:19:03
|
On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: > Hi developers, > > Please find a patch attached to this mail that solves a couple of > memory-corruption issues, and a couple of 64-bit mode options. > > The "unsigned int" -> "size_t" type changes are 64-bit fixes; when not > using these, one gets offsets in the > 2^31 range at times. > > The changes to exif-data.c prevent reading from e->data when e->data > is NULL, and to prevent calling exif_data_save_data_entry if > ifd->entries[j] is NULL. > > An additional set of changes within the maker-note files are to > prevent crashing on sizes > 64kb; It seems that the maker-notes, at > times, return sizes that are huge (as in: way beyond 2^31 bytes). > According to the documentation, though, the full size of the EXIF data > should fit within a JPEG section, thus intrinsically limiting it to 64 > kb. I.e.: any s that is > 64 kb indicates a problem within the data. Is this diff the right way round? It seems you diffed new -> old instead of old -> new Also please use diff -u Ciao, Marcus |
From: Dan F. <da...@co...> - 2008-09-25 17:31:52
|
On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: > Please find a patch attached to this mail that solves a couple of > memory-corruption issues, and a couple of 64-bit mode options. Would you mind resending the patch in unified diff format (-u)? It's more reliable to apply and to review that way. >>> Dan -- http://www.MoveAnnouncer.com The web change of address service Let webmasters know that your web site has moved |
From: Niek B. <ni...@go...> - 2008-09-25 10:20:30
|
Hi developers, Please find a patch attached to this mail that solves a couple of memory-corruption issues, and a couple of 64-bit mode options. The "unsigned int" -> "size_t" type changes are 64-bit fixes; when not using these, one gets offsets in the > 2^31 range at times. The changes to exif-data.c prevent reading from e->data when e->data is NULL, and to prevent calling exif_data_save_data_entry if ifd->entries[j] is NULL. An additional set of changes within the maker-note files are to prevent crashing on sizes > 64kb; It seems that the maker-notes, at times, return sizes that are huge (as in: way beyond 2^31 bytes). According to the documentation, though, the full size of the EXIF data should fit within a JPEG section, thus intrinsically limiting it to 64 kb. I.e.: any s that is > 64 kb indicates a problem within the data. Regards, Niek Bergboer Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1 |
From: Translation P. R. <ro...@tr...> - 2008-09-08 19:47:11
|
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'exif' has been submitted by the Danish team of translators. The file is available at: http://translationproject.org/latest/exif/da.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/exif/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/exif.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. <coo...@tr...> |
From: Translation P. R. <ro...@tr...> - 2008-09-04 14:22:09
|
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'libexif' has been submitted by the Dutch team of translators. The file is available at: http://translationproject.org/latest/libexif/nl.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/libexif/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/libexif.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. <coo...@tr...> |
From: Translation P. R. <ro...@tr...> - 2008-09-04 10:32:14
|
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'libexif' has been submitted by the Dutch team of translators. The file is available at: http://translationproject.org/latest/libexif/nl.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/libexif/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/libexif.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. <coo...@tr...> |
From: Translation P. R. <ro...@tr...> - 2008-07-31 16:02:11
|
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'exif' has been submitted by the Indonesian team of translators. The file is available at: http://translationproject.org/latest/exif/id.po (We can arrange things so that in the future such files are automatically e-mailed to you when they arrive. Ask at the address below if you want this.) All other PO files for your package are available in: http://translationproject.org/latest/exif/ Please consider including all of these in your next release, whether official or a pretest. Whenever you have a new distribution with a new version number ready, containing a newer POT file, please send the URL of that distribution tarball to the address below. The tarball may be just a pretest or a snapshot, it does not even have to compile. It is just used by the translators when they need some extra translation context. The following HTML page has been updated: http://translationproject.org/domain/exif.html If any question arises, please contact the translation coordinator. Thank you for all your work, The Translation Project robot, in the name of your translation coordinator. <coo...@tr...> |
From: Marcus M. <ma...@je...> - 2008-07-27 21:03:08
|
On Sat, Jul 26, 2008 at 04:06:53PM +0000, Jan Patera wrote: > Update of /cvsroot/libexif/libexif/libexif > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11556 > > Modified Files: > exif-content.c > Log Message: > Hopefully finally correct ;-) Looks good now, eog nor gimp dont crash. Ciao, Marcus > > Index: exif-content.c > =================================================================== > RCS file: /cvsroot/libexif/libexif/libexif/exif-content.c,v > retrieving revision 1.28 > retrieving revision 1.29 > diff -u -p -d -r1.28 -r1.29 > --- exif-content.c 26 Jul 2008 14:26:43 -0000 1.28 > +++ exif-content.c 26 Jul 2008 16:06:49 -0000 1.29 > @@ -175,9 +175,10 @@ exif_content_remove_entry (ExifContent * > } > c->entries = t; > c->count--; > - if (i!=c->count) /* we deallocated the last slot already */ > + if (i != c->count) { /* we deallocated the last slot already */ > memmove (&t[i], &t[i + 1], sizeof (ExifEntry*) * (c->count - i - 1)); > - t[c->count-1] = temp; > + t[c->count-1] = temp; > + } > } else { > exif_mem_free (c->priv->mem, c->entries); > c->entries = NULL; > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > libexif-cvs mailing list > lib...@li... > https://lists.sourceforge.net/lists/listinfo/libexif-cvs > |
From: Jan P. <pa...@pi...> - 2008-07-27 08:50:12
|
Hi, > Modified Files: > exif-tag.c > Log Message: > gracefully return 0 when the name has not been found ..... > exif_tag_from_name (const char *name) > { > unsigned int i; > + unsigned int result=0; > > if (!name) return 0; > > for (i = 0; ExifTagTable[i].name; i++) > - if (!strcmp (ExifTagTable[i].name, name)) break; > - return ExifTagTable[i].tag; I am curious - did the old code really behave differently than the new one? If the name is not found, at the end ExifTagTable[i].name is NULL and therefore also ExifTagTable[i].tag is NULL. Or am I overlooking something? -- Jan > + if (!strcmp (ExifTagTable[i].name, name)) { > + result = ExifTagTable[i].tag; > + break; > + } > + return result; > } |
From: Mika R. <mi...@go...> - 2008-06-23 11:28:55
|
Attached. The bug was what if you set a logger with exif_loader_log(), it would increment the refcount on the logger, but exif_loader_free would not decrement it, leaking the logger. Regards, Mika Raento |
From: matthieu c. <cas...@fr...> - 2008-06-15 17:25:11
|
Lutz Müller wrote: > On Sat, 2008-06-14 at 19:58 +0200, matthieu castet wrote: >> I need to change exif usercomment. I update the exif tools to do that. >> See the attached patch for cvs. > > I checked in a slightly modified version (for exemple: avoid checking > for e->data 2 times). Ok, thanks. But now it always resize the user comment tag and my patch avoid that by using 0 padding. > >> I don't manage to build cvs > > Have you tried autoreconf -vis? No, will try. > >> all the exif data are rewritten and are different from >> the original picture. >> This shouldn't happen because I only update usercomment without changing >> the tag size. > > libexif doesn't modify in place. It loads/saves all EXIF data. By > default, after loading the EXIF data, libexif makes sure that the EXIF > data follows the specification (EXIF_DATA_OPTION_FOLLOW_SPECIFICATION). > If the EXIF data you get is different from the EXIF data you supplied > (with regard to the content), check if the EXIF data supplied follows > the specification. Have a look at the debug messages using the -d > command line option. Using my patch (usercomment tag size not changed), the difference with -d is [1]. exiv2 also report difference for ExifTag(0x8769) and InteroperabilityTag(0xa005). May be libexif when rewriting the tags remove some padding ? [1] --- /tmp/1 2008-06-15 18:32:44.000000000 +0200 +++ /tmp/2 2008-06-15 18:32:40.000000000 +0200 @@ -1,5 +1,5 @@ ExifLoader: Scanning 1024 byte(s) of data... -ExifData: Parsing 11262 byte(s) EXIF data... +ExifData: Parsing 8931 byte(s) EXIF data... ExifData: Found EXIF header. ExifData: Found EXIF header. @@ -50,13 +50,13 @@ ExifData: Loading entry 0xa403 ('WhiteBalance')... ExifData: Loading entry 0xa404 ('DigitalZoomRatio')... ExifData: Loading entry 0xa406 ('SceneCaptureType')... -ExifData: IFD 1 at 3158. +ExifData: IFD 1 at 3136. ExifData: Loading 6 entries... ExifData: Loading entry 0x103 ('Compression')... ExifData: Loading entry 0x11a ('XResolution')... ExifData: Loading entry 0x11b ('YResolution')... ExifData: Loading entry 0x128 ('ResolutionUnit')... -EXIF tags in '/tmp/IMG_0872.JPG' ('Intel' byte order): +EXIF tags in '/tmp/IMG_0872.JPG.modified.jpeg' ('Intel' byte order): --------------------+---------------------------------------------------------- Tag |Value --------------------+---------------------------------------------------------- @@ -86,8 +86,8 @@ Metering Mode |Pattern Flash |Flash did not fire, compulsory flash mode. Focal Length |8.3 mm -Maker Note |2138 bytes unknown data -User Comment |Marseille : Cath +Maker Note |2124 bytes unknown data +User Comment |mct FlashPixVersion |FlashPix Version 1.0 Color Space |sRGB PixelXDimension |2592 |