#90 libexif-gtk: Port to new API

closed
libexif-gtk (4)
5
2013-02-23
2008-07-09
No

Here is a patch to port libexif-gtk to the new libexif API.

libexif-gtk-libexif.patch:
Patch that ports to the new syntax of gtk_list_store_set() and exif_entry_get_value()
Author: Marcus Meissner

gtk-exif-libexif-no-deprecated.patch:
Patch that gets rid use of broken-by-design exif_tag_get_name()
Author: me

Second patch discovers hole in the libexif API: missing function for getting all known tags. Additionally, definition of ExifTag as enum is not wise, as some tags are not unique. They are unique only per IFD.

Discussion

  • Stanislav Brabec

    Logged In: YES
    user_id=616997
    Originator: YES

    File Added: libexif-gtk-no-deprecated.patch

     
  • Stanislav Brabec

    Logged In: YES
    user_id=616997
    Originator: YES

    Update: In patch libexif-gtk-no-deprecated.patch, chunk adding new include to libexif-gtk/gtk-exif-tag-menu.c is not needed.

     
  • Dan Fandrich

    Dan Fandrich - 2009-10-22
    • labels: --> libexif-gtk
     
  • Dan Fandrich

    Dan Fandrich - 2013-02-23

    The no-deprecated patch has been applied--thanks. The equivalent of the libexif API patch was already in a previous release. That libexif API hole is a known limitation that noone has bothered to remedy yet. I agree about fixing the ExifTag enum problem, but it's impossible to do in a ABI-compatible and portable manner due to differences in the size of enum and ints on some systems. It's on my list of things to fix in the next ABI imcompatible libexif release (for which there are no current plans).

     
  • Dan Fandrich

    Dan Fandrich - 2013-02-23
    • assigned_to: nobody --> dfandrich
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks