Menu

#120 exif_tag_table_count fails to link with non-gcc compilers

None
closed-fixed
5
2018-06-29
2014-04-14
No

exif_tag_table_count is marked inline, but it doesn't need to be. When libexif is built with a C99 compiler like clang or gcc -std=c99, it won't necessarily be emitted into the object file, and users won't be able to call it.

Similarly, MSVC isn't able to compile and link libexif if using the new /Zc:inline flag.

Any reasonable compiler is going to inline exif_tag_table_count inside the exif-tag.c TU, so there's really no reason to manually mark it inline and deal with all the complexity it implies. Please remove the specifier.

I encountered this while trying to build Chromium on Windows:
https://code.google.com/p/chromium/issues/detail?id=363299

Discussion

  • Dan Fandrich

    Dan Fandrich - 2018-06-29

    Fixed in 80ed9dff. Thanks for the report!

     
  • Dan Fandrich

    Dan Fandrich - 2018-06-29
    • status: open --> closed-fixed
    • assigned_to: Dan Fandrich
    • Group: -->
     

Log in to post a comment.

MongoDB Logo MongoDB