#106 Does 0.6.20-mnote_fuji_tag_get_description have a problem ?

closed-fixed
libexif (61)
2
2011-07-12
2011-05-25
Lee Gun-woo
No

"Segmentation fault" defect found on "mnote_fuji_tag_get_desciption" and "mnote_canon_tag_get_descripton" functions.

It looks
"if (!*table[i].description)" sentence should be changed like olympus and pentax's one.
If table[i].description is NULL then "Segmentation fault" will be happened because of NULL reference.

ver : LIBexif 0.6.20

Discussion

  • Lee Gun-woo

    Lee Gun-woo - 2011-05-25
    • summary: 0.6.20-mnote_fuji_tag_get_description has a problem --> 0.6.20-mnote_fuji_tag_get_description has a problem ?
     
  • Lee Gun-woo

    Lee Gun-woo - 2011-07-12
    • priority: 5 --> 9
    • summary: 0.6.20-mnote_fuji_tag_get_description has a problem ? --> Does 0.6.20-mnote_fuji_tag_get_description have a problem ?
     
  • Dan Fandrich

    Dan Fandrich - 2011-07-12
    • priority: 9 --> 2
    • assigned_to: nobody --> dfandrich
    • status: open --> open-fixed
     
  • Dan Fandrich

    Dan Fandrich - 2011-07-12

    None of the Fuji mnote descriptions are NULL, so this isn't actually a problem in the current code. But, it doesn't hurt to be defensive, so I've applied your suggested patch. Thanks!

     
  • Dan Fandrich

    Dan Fandrich - 2011-07-12
    • status: open-fixed --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks