Menu ▾ ▴

#40 export messes up when samples_this_frame == 0

open-accepted
Dan Dennedy
None
5
2006-09-03
2006-09-02
No

This patch for libdv-0.104. It addresses a minor
problem with exporting to a RAW DV file where audio
noise is introduced. The problem arises when
samples_this_frame == 0 and dv_encode_full_audio()
calculates audio.bytesperframe. When bytesperframe is
calculated, its units are bytes (correct), but
_dv_raw_insert_audio() then assumes the units are
samples (wrong).

In contrast, when samples_this_frame != 0,
audio.bytesperframe is set to samples_this_frame and
_dv_raw_insert_audio() is then correct to treat the
value as samples. So depending on samples_this_frame,
the units of audio.bytesperframe is either bytes or
samples.

This patch corrects the use of audio.bytesperframe so
units are always bytes.

Discussion

  • Anonymous

    Anonymous - 2006-09-02

    patch for dv export

     
    libdv-0.104-encode.patch

  • Dan Dennedy

    Dan Dennedy - 2006-09-03

    Logged In: YES
    user_id=78682

    Thanks, I applied it to CVS as of ChangeLog Rev 1.120.

     

  • Dan Dennedy

    Dan Dennedy - 2006-09-03
    • assigned_to: nobody --> ddennedy
    • status: open --> open-accepted
     
MongoDB Logo MongoDB