[libdv-dev] [ libdv-Patches-1550898 ] export messes up when samples_this_frame == 0

[SourceForge.net <no...@so...>]

Patches item #1550898, was opened at 2006-09-01 23:31
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304393&aid=1550898&group_id=4393

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Craig Lawson (claw11)
Assigned to: Nobody/Anonymous (nobody)
Summary: export messes up when samples_this_frame == 0

Initial Comment:
This patch for libdv-0.104. It addresses a minor
problem with exporting to a RAW DV file where audio
noise is introduced. The problem arises when
samples_this_frame == 0 and dv_encode_full_audio()
calculates audio.bytesperframe. When bytesperframe is
calculated, its units are bytes (correct), but
_dv_raw_insert_audio() then assumes the units are
samples (wrong).

  In contrast, when samples_this_frame != 0,
audio.bytesperframe is set to samples_this_frame and
_dv_raw_insert_audio() is then correct to treat the
value as samples. So depending on samples_this_frame,
the units of audio.bytesperframe is either bytes or
samples.

  This patch corrects the use of audio.bytesperframe so
units are always bytes.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=304393&aid=1550898&group_id=4393