[libdv-dev] [ libdv-Bugs-1484362 ] dv_decoder_new: ignores first parameter ("add_ntsc_setup")

[SourceForge.net <no...@so...>]

Bugs item #1484362, was opened at 2006-05-09 04:09
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104393&aid=1484362&group_id=4393

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: David Foster (crystalline)
Assigned to: Nobody/Anonymous (nobody)
Summary: dv_decoder_new: ignores first parameter ("add_ntsc_setup")

Initial Comment:
If you read the source code for dv_decoder_new, you'll
notice that it completely ignores its first parameter.

--------------------------------------------------------
dv_decoder_t * 
dv_decoder_new(int add_ntsc_setup, int clamp_luma, int
clamp_chroma) {
  dv_decoder_t *result;
  
  result = (dv_decoder_t *)calloc(1,sizeof(dv_decoder_t));
  if(!result) goto no_mem;
  
  result->add_ntsc_setup = FALSE;  // *** BUG! ***
  result->clamp_luma = clamp_luma;
  result->clamp_chroma = clamp_chroma;
--------------------------------------------------------

I suspect that the marked line in the above source code
should read as:

  result->add_ntsc_setup = add_ntsc_setup;

At present the only way to work around this is to
manually set the "add_ntsc_setup" field of the returned
dv_decoder structure with the desired configuration
setting.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=104393&aid=1484362&group_id=4393