|
From: Olivier C. <ocr...@fr...> - 2008-06-01 05:49:11
Attachments:
dvsplit.c
|
Hi all For my own needs, I have written a command line utility based on libdv to split a DV file in smaller DV files based on the frame timestamps. It may be useful to other people, so I post it here. Is there also a way to include it in the libdv distribution? Best regards Olivier |
|
From: Bernhard K. <bk...@su...> - 2008-06-05 14:45:20
|
Hi Olivier, On Sun, 1 Jun 2008, Olivier Croquette wrote: > > Hi all > > For my own needs, I have written a command line utility based on libdv to > split a DV file in smaller DV files based on the frame timestamps. > > It may be useful to other people, so I post it here. Is there also a way to > include it in the libdv distribution? > > Best regards > > Olivier while I can't speak for the authors of libdv, I can give you my perspective as the maintainer of the libdv package in openSUSE: libdv C source files (including tools like playdv, excluding man pages, which are licensed under the GPL) appear to be licensed by using these license header in the files: * This file is part of libdv, a free DV (IEC 61834/SMPTE 314M) * codec. * * libdv is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser Public License as published by * the Free Software Foundation; either version 2.1, or (at your * option) any later version. * * libdv is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser Public License for more details. * * You should have received a copy of the GNU Lesser Public License * along with libdv; see the file COPYING. If not, write to * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. * * The libdv homepage is http://libdv.sourceforge.net/. That means the source code of libdv seems to be released under LGPL v2.1 or newer. The license header which you used uses GPLv3. To your file as is to libdv, one would have to add the GPLv3 COPYING file as COPYING.GPLv3 and indicate that dvsplit is licensed under GPLv3 while the rest is LGPL v2.1. Just to not complicate things for adding one utility, I'd prefer if you would license dvsplit under LGPL v2.1 using the same license header as the other C files use. To make the name consistent with playdv and encodedv, I'd name it splitdv. It would also be needed to have a manual page for dvsplit/splitdv, you can likely take e.g. the file playdv.1 as base and copy the entries in Makefile{,in,am} from playdv.1 to cause that the the autoconf/make process builds and installs your man page. If you then create a patch between the old and the new libdv tree using 'diff -u', people could add it to their libdv builds, and it would make it also easyer for Dan Dennedy <da...@de...> to add it to the CVS repository of libdv. You may want to contact Dan directly if you are unsure wether creating a man page and an update patch with 'diff -u' which compiles and installs the tool and its man page is something for you, but I guess it could help, especially the availability of a man page and using the same license as the rest of libdv should help. Bernhard |
|
From: Olivier C. <ocr...@fr...> - 2008-06-05 15:22:43
|
Bernhard Kaindl wrote, On 5/06/08 16:45: > Just to not complicate things for adding one utility, I'd prefer if you would > license dvsplit under LGPL v2.1 using the same license header as the other C > files use. Sure, I don't really care. > To make the name consistent with playdv and encodedv, I'd name it splitdv. OK. I will try to sort your other recommendations out soon and provide a nice patch. BR Olivier |
|
From: Olivier C. <ocr...@fr...> - 2008-06-28 14:07:54
|
Hi all Here is the corresponding patch for splitdv, with the man page. Comments (or inclusion :)) welcome. I can't test the integration in the libdv build chain, I still have difficulties unterstanding the autotools... Best regards Olivier |
|
From: Olivier C. <ocr...@fr...> - 2008-06-28 14:10:32
Attachments:
splitdv.patch
|
Olivier Croquette wrote, On 28/06/08 16:07: > Here is the corresponding patch for splitdv, with the man page. > Comments (or inclusion :)) welcome. Like always, I forgot the attachment. Here it is. |
|
From: Bernhard K. <bk...@su...> - 2008-06-30 10:20:50
|
On Sat, 28 Jun 2008, Olivier Croquette wrote: > > Hi all > > Here is the corresponding patch for splitdv, with the man page. > Comments (or inclusion :)) welcome. > > I can't test the integration in the libdv build chain, I still have > difficulties unterstanding the autotools... Does not look bad at least. You should be able to test the integration into the libdv build chain (which uses the GNU autotools) by running for example these commands in a copy of your changed libdv directory: libtoolize --copy --force automake autoconf ./configure ... make This should rebuild the libdv autotools build setup and build libdv with them. If you get a working splitdv binary from them, at least the most important basics should be ok. Did you get an answer from Dan Dennedy <da...@de...> about including the patch? About the license, I saw that you agreed to license it under LGPL v2.1 using the same license header as the other C files of libdv: Bernhard Kaindl wrote: >Olivier Croquette wrote: >> Just to not complicate things for adding one utility, I'd prefer if you would >> license dvsplit under LGPL v2.1 using the same license header as the other C >> files use. > > Sure, I don't really care. I just saw that you didn't replace the license header of splitdv.c: + dvsplit.c + + Copyright (C) Olivier Croquette, 2008 + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, version 3. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. The header should look similar to this one (referring to LGPL v2.1): * splitdv.c * * Copyright (C) Olivier Croquette, 2008 * * This file is part of libdv, a free DV (IEC 61834/SMPTE 314M) * codec. * * libdv is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser Public License as published by * the Free Software Foundation; either version 2.1, or (at your * option) any later version. * * libdv is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser Public License for more details. * * You should have received a copy of the GNU Lesser Public License * along with libdv; see the file COPYING. If not, write to * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. * * The libdv homepage is http://libdv.sourceforge.net/. Sourceforge also has a section "patches" (below Tracker) which where you can publish the final patch using an (free) developer account at sf.net: http://sourceforge.net/tracker/?group_id=4393&atid=304393 Bernhard |
|
From: Dan D. <da...@de...> - 2008-06-30 16:59:45
|
On Mon, Jun 30, 2008 at 3:04 AM, Bernhard Kaindl <bk...@su...> wrote: > Did you get an answer from Dan Dennedy <da...@de...> about including > the patch? I see no point in this really because I no longer actively work on libdv (no one does), it would likely not be released, and it is redundant with dvgrab. dvgrab already reads dv from stdin and has several file splitting and file naming options. However, I did not want to respond immediately with any words of discouragement, but now you have put me on the spot ;-). I do strongly suggest adding it to the SourceForge tracker. Then, if there ever is a new libdv release, it might get included. -- +-DRD-+ |
|
From: Olivier C. <ocr...@fr...> - 2008-06-30 17:27:47
|
Dan Dennedy wrote, On 30/06/08 18:59: > dvgrab already reads dv from stdin and has > several file splitting and file naming options. However, I did not > want to respond immediately with any words of discouragement, but now > you have put me on the spot ;-). Well I am not really keen on reinventing the wheel, so I would of course have appreciated a word about dvgrab sooner. It wouldn't have solve my problem though, since dvgrab is not trivial to port to my platform (MacOS X) which doesn't have libraw1394. > I do strongly suggest adding it to > the SourceForge tracker. Then, if there ever is a new libdv release, > it might get included. OK, even if, to get "officially" the DV splitting on MacOS X, the chances look better to adapt dvgrab and create a port for the MacOS X platform. |