Re: [libdc] fix for USB3 transfer errors

[Damien D. <dd...@do...>]

On Thu, 2017-04-20 at 17:25 -0400, Zahniser, Michael wrote:
> I heard back from Point Grey / FLIR, and their engineer confirmed that
> the change I'm proposing would work for all their IIDC-over-USB3
> cameras. He said:
> 
> 
> "I asked about this internally and confirmed the image data when sent
> from a USB3 camera does not have padding. If you allocate your own
> image buffers, we do recommend your buffer size to be aligned to 1024
> as discussed in my previous message, though."
> 
> A change to pad the USB3 buffer size to a multiple of 1024 bytes (the
> size of one USB3 packet) is included below. It seems to work fine
> without this change, so I'm not sure whether it's better to add it
> "just in case," or to play it safe and avoid making code changes that
> are not proven to be necessary. I've only tested on Linux, so it's
> possible that Point Grey's recommendation is because the padding is
> necessary on another OS.

Thanks Michael!

I would go for their recommendation since they're the only ones making
IIDC-on-USB3 cameras.

Patch applied, as well as the bad argument type you mentioned in your
previous email (my indentation mess was also fixed by your new patch :)

I'll wait a couple of days and if nothing comes up it will be time for a
new minor release.

Cheers,

Damien

-- 
Damien 高原 Douxchamps    http://damien.douxchamps.net/