[libdbi-devel] [ libdbi-Bugs-1577286 ] core dump in dbi_main.c _error_handler()

[SourceForge.net <no...@so...>]

Bugs item #1577286, was opened at 2006-10-14 19:37
Message generated for change (Comment added) made by mhoenicka
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379806&aid=1577286&group_id=23824

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Submitted By: Peter MacDonald (pcmacdon)
Assigned to: Nobody/Anonymous (nobody)
Summary: core dump in dbi_main.c _error_handler()

Initial Comment:
In _error_handler() a free() is performed 
when the new value == old value, in essence
freeing itself.  This is causing random core dumps.

I also added a sanity check before access to
errflag_messages[]..

Attached is a patch.

----------------------------------------------------------------------

>Comment By: Markus Hoenicka (mhoenicka)
Date: 2006-10-16 22:25

Message:
Logged In: YES 
user_id=85809

I've analyzed the situation again, and I still maintain
there is no need to fix dbi_main.c. The situation where new
value == old value, resulting in a NULL assignment, can only
arise if a driver abuses the error message system. This has
unfortunately been the case for the sqlite and sqlite3
drivers. See the discussion for bug #1577808 (reassigned to
libdbi-drivers from #1577323). I'll close this bug as it
appears to be a libdbi-drivers problem.

----------------------------------------------------------------------

Comment By: Peter MacDonald (pcmacdon)
Date: 2006-10-16 05:16

Message:
Logged In: YES 
user_id=190660

Unfortunately, that's no possible.  I didn't even start
working on the #1577323 problem until a couple of hours
after I had found and fixed this core dump problem.

----------------------------------------------------------------------

Comment By: Markus Hoenicka (mhoenicka)
Date: 2006-10-15 23:46

Message:
Logged In: YES 
user_id=85809

I've tried to figure out what's wrong here, and I believe
this patch is only required after the patch provided for bug
#1577323 is applied. I've appended an alternative patch for
#1577323. Could you please check whether the problem you
mentioned in this bug report persist after you applied that
patch? Thanks.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=379806&aid=1577286&group_id=23824