Re: [libdbi-devel] [PATCH] Zero-byte allocations in _dbd_result_set_numfields

[Ashish R. <ash...@ya...>]

Hi sami,
  Thanks for your contrib. Can you contribute the
automated valgrind test suite script (if it can be
automated), so that before release of each version ,
we can do a "make valgrindtest" and the test suite
runs many checks and displays the status. I think
automated test cases suit will improve our quality of
testing and stability.
bye :-)
Ashish

--- Markus Hoenicka <mar...@mh...>
wrote:

> Hi Sami,
> 
> thanks for the patch. I'll give it a try. I assume
> that valgrind is happy with
> the patch, but I'd like to review the source code to
> make sure we never try to
> touch the non-allocated memory.
> 
> regards,
> Markus
> 
> Sami Tolvanen <sa...@to...> was heard to say:
> 
> > I received a number of warnings about zero-byte
> allocations when running
> > an application that uses libdbi under valgrind.
> >
> > It seems that the memory allocated in
> _dbd_result_set_numfields is never
> > freed in dbi_result_free if result->numfields is
> zero. Yet, calloc seems
> > to allocate some resources even if the first
> argument is zero, therefore
> > leading to a slow memory leak.
> >
> > Below is a suggested patch to fix
> _dbd_result_set_numfields.
> >
> > 	Sami
> >
> >
> > --- dbd_helper.c.orig	2005-12-07
> 18:01:26.000000000 +0200
> > +++ dbd_helper.c	2005-12-07 17:45:43.000000000
> +0200
> > @@ -85,9 +85,11 @@
> >
> >  void _dbd_result_set_numfields(dbi_result_t
> *result, unsigned int numfields)
> > {
> >  	result->numfields = numfields;
> > -	result->field_names = calloc(numfields,
> sizeof(char *));
> > -	result->field_types = calloc(numfields,
> sizeof(unsigned short));
> > -	result->field_attribs = calloc(numfields,
> sizeof(unsigned int *));
> > +	if (numfields > 0) {
> > +		result->field_names = calloc(numfields,
> sizeof(char *));
> > +		result->field_types = calloc(numfields,
> sizeof(unsigned short));
> > +		result->field_attribs = calloc(numfields,
> sizeof(unsigned int *));
> > +	}
> >  }
> >
> >  void _dbd_result_add_field(dbi_result_t *result,
> unsigned int idx, char
> > *name, unsigned short type, unsigned int attribs)
> {
> >
> >
> >
>
-------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do
> you grep through log files
> > for problems?  Stop!  Download the new AJAX search
> engine that makes
> > searching your log files as easy as surfing the 
> web.  DOWNLOAD SPLUNK!
> >
>
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> > _______________________________________________
> > libdbi-devel mailing list
> > lib...@li...
> >
>
https://lists.sourceforge.net/lists/listinfo/libdbi-devel
> >
> 
> 
> -- 
> Markus Hoenicka
> mar...@ca...
> (Spam-protected email: replace the quadrupeds with
> "mhoenicka")
> http://www.mhoenicka.de
> 
> 
> 
>
-------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do
> you grep through log files
> for problems?  Stop!  Download the new AJAX search
> engine that makes
> searching your log files as easy as surfing the 
> web.  DOWNLOAD SPLUNK!
>
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> libdbi-devel mailing list
> lib...@li...
>
https://lists.sourceforge.net/lists/listinfo/libdbi-devel
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com