Re: [libdbi-devel] Patch(over 0.8.0pre3) for compiling libdbi core on mingw+msys

[Markus H. <mar...@mh...>]

Hi Ashish,

Ashish Ranjan <ash...@ya...> was heard to say:

> I had released one addon patch to compile libdbi
> (core) 0.7.x on mingw+msys .Today, i ported that for
> 0.8.0 pre3 code base, and here i submit my changes. If
> it is incorporated, then on windows , we can compile
> libdbi on mingw+msys (apart from the cygwin) out of
> the box.
>

I recall your earlier attempt, but I wasn't promoted to libdbi maintainer back
then, so I didn't follow up on this. Your patches are very welcome, of course.

> Please note that Change 1.1 and 1.2 involve only
> renaming two variables

No big deal.

> And Change 1.3 and 2.1 only are significant change,
> but these are put inside
>     #ifdef ..
> 	  ...
> 	#elif __MINGW32__
> 	 ..
> 	#else
> 	 ..
> 	#endif.

OSX needs special treatment at this point too, so this is nothing to worry
about.

> NOTE: by default , there is no directory /usr/local in msys, though /usr
> exists. So you should mkdir /usr/local, so as use /usr/local/lib etc.

I believe this can be handled when configuring libdbi. Something like
./configure --prefix=/usr will install libdbi in /usr/lib. Even if you use
/usr/local, the mkinstalldirs script should create it. Or does mingw bypass
configure and the configure-created makefiles altogether?

Two minor issues:

- It is easier for me to look at diffs instead of at modified full files. If
possible, send the output of diff -U 3 oldfile newfile > oldfile.diff next
time.

- You've edited the source files on Windows which introduces \r\n linebreaks. If
possible, please use an editor that creates Unix-style linebreaks (jedit,
NTEmacs  or one of many other free programmer's editors for Windows).

I'll use and clean up the files you sent this time though.

regards,
Markus

-- 
Markus Hoenicka
mar...@ca...
(Spam-protected email: replace the quadrupeds with "mhoenicka")
http://www.mhoenicka.de