[libdbi-devel] libdbi-drivers problems

[<mar...@mh...>]

Peter Czanik writes:
 > Hello,
 > I don't know if it's a problem in libdbi-drivers code or in openSUSE 
 > Build Service code checking scripts (I can't code in C, just 
 > package...), but right now I can't package libdbi-drivers as I get the 
 > following warnings and error:
 > 
 > [   11s] I: Program is using implicit definitions of functions getting
 > [   11s]    pointers or implemented by macros. These functions need to 
 > use their
 > [   11s]    correct prototypes to allow correct argument passing on e.g. 
 > x86_64 .
 > [   11s]      - Implicit memory/string functions need #include <string.h>.
 > [   11s]      - Implicit *printf functions need #include <stdio.h>.
 > [   11s]      - Implicit *printf functions need #include <stdio.h>.
 > [   11s]      - Implicit *read* functions need #include <unistd.h>.
 > [   11s]      - Implicit *recv* functions need #include <sys/socket.h>.
 > [   11s] W: libdbi-drivers implicit-pointer-decl src/unit.c:229
 > [   11s] E: libdbi-drivers 64bit-portability-issue src/constraint.c:167, 168
 > 
 > The full log is available at 
 > https://build.opensuse.org/package/rawlog?arch=x86_64&package=libdbi-drivers&project=home%3Aczanik%3Alibdbi&repository=openSUSE_Factory
 > Could you take a look at it?

Hi,

the offending code appears to be in the copy of cgreen which we ship
as a test harness along with the libdbi-drivers sources. I don't fully
understand what the code checking scripts complain about but
apparently some of the prototypes in the include files rely on global
include files which are only included *after* the local include
files. The appended patches revert the order of includes. Could you
please check if that helps?

regards,
Markus