Re: [libdbi-devel] Branch-2009-10-12 test status

[Markus H. <mar...@mh...>]

Quoting João Henrique Freitas <jo...@gm...>:

> Please show me your idea about:  "rearrange the code in test_dbi.c to
> separate driver-specific code from non-specific code".
>
> In the test framework exists some tests written to specific driver like:
>
> if (mysql)
>   do...
> else if (pgsql)
>  do...
>

Hi,

the idea is simply to move all functions that contain code like the  
one cited above to the top of the file, and all functions which are  
driver-independent (either by nature, or by means of the accessor  
functions) below a line reading "no driver-specific stuff below". I  
often do this in scripts to make clear where to fiddle with the code  
and where not, if customizations are required. I figured this might  
ease the task of adding drivers or modifying driver tests.

As for the rest, I'll have a look at your work as soon as time permits.

regards,
Markus


-- 
Markus Hoenicka
http://www.mhoenicka.de
AQ score 38