#25 Memory leak in sqlite and sqlite3 drivers - dbd_ping()

[rv4m]

in drivers/sqlite3/dbd_sqlite3.c / dbd_ping()
in drivers/sqlite/dbd_sqlite.c / dbd_ping()

dbd_query() result is not freed (leaking):

int dbd_ping(dbi_conn_t *conn) {

if (dbd_query(conn, "SELECT 1") == NULL) {
return 0;
}
else {
return 1;
}
}

it should be something like:

int dbd_ping(dbi_conn_t *conn) {
dbi_result dbi_result;

dbi_result = dbd_query(conn, "SELECT 1")
if (dbi_result == NULL) {
return 0;
}
else {
dbi_result_free(dbi_result);
return 1;
}
}

[rv4m]

Patch attached.

[Markus Hoenicka]

rv4m writes:

xmultipart message, 1 part [Click mouse-2 to display parts]

fixed in revision 1.50 of dbd_sqlite3.c. Thanks for the report.

Markus

--
Markus Hoenicka
http://www.mhoenicka.de
AQ score 38