Re: [Libclc-developers] Re: Some more comments to the current CVS tree

[Hallvard B F. <h.b...@us...>]

Jan Engelhardt writes:
>>> src/clc_stralloc.c:
>>>   va_start() is used two times. IIRC, such use is not recommended,
>>>   for whatever reason. IIRC.
>>>   They propose va_copy() instead.
>>
>>Can't.  va_copy() is a C99 macro.  It's not defined in C89.
> 
> Still, side effects may occur. (Still suggesting ap2=ap1 before doing
> any va_start, need we?)

That shouldn't hurt.  But let's take it to c.l.c.

> I mean, if strcpy() is in the C89 standard, why doesnot stpcpy use
> strcpy?

Because it's hopefully faster not to.  It avoids a strlen() call.

>>> doc/string/*
>>>   General indent question. Some files have 4 some have 2 leading.
>
> (Meant some files have 8 for paragraphs (4 for subheadings), whereas
> others had 4 for paragraphs and 2 for subheadings)

Oops, I didn't notice you were talking about doc not src.  Anyway, it's
fixed now.

-- 
Hallvard