Menu ▾ ▴

#7 Eject ioctl error resolved

Unstable_(example)
open
nobody
eject (1)
1
2023-03-03
2019-05-10
Jacek Ruzyczka
No

As described in bug #8, the eject command resp. the cd_eject ()method fails because of an I/O error in ioctl. Examination of the eject utility showed that at least some USB CD drives only support the SCSI eject command sequence, not the well-known CDROMEJECT.

So I copied most of the eject_scsi () method from eject.c, implanted it into cdaudio.c with minor adaptations and added a fallback into cd_eject (), which is called whenever CDROMEJECT fails. Tests proved successful, but could someone else please perform some extra tests? Thank you.

1 Attachments
cdaudio.c

Discussion

  • Jacek Ruzyczka

    Jacek Ruzyczka - 2019-05-10

    Sorry, typo in the sourcecode!

     
    cdaudio.c

  • Fabrice Bauzac

    Fabrice Bauzac - 2019-05-11

    Perfect! However, cdcd/libcdaudio is looking for a maintainer. Would you accept becoming a maintainer, so that you can integrate the change directly?

     

  • Jacek Ruzyczka

    Jacek Ruzyczka - 2019-05-11

    I can accept your proposal, but I'm too busy to contribute to this project regularly.

     

    • Sebastian Rasmussen

      Sebastian Rasmussen - 2022-09-03

      Hey!

      I tested your patch and (as expected) it works flawlessly (as does eject(1)!). Do you mind getting this patch into libcdaudio so I can enjoy it in Debian/testing without having to patch libraries? :)

      / Sebastian

       

      • Fabrice Bauzac

        Fabrice Bauzac - 2023-03-03

        Hi @sebras,
        libcdaudio is looking for a maintainer.
        Would you accept becoming a maintainer of the project, and apply the patch yourself?

         

Log in to post a comment.