Menu

#3 issues with BUFFSERSIZE macro

open
nobody
None
5
2018-12-10
2012-11-30
Jakub Wilk
No

User has to define BUFFERSIZE macro to be able to use C++ headers. There are two problems with this approach:
- This is a very generic name; user might want to use it for its own purpose. Please rename it to something clearly libb64-specific, e.g. LIBB64_BUFFERISZE.
- There should be no need to define a macro in the first place. Please provide a sensible default if the macro is not defined.

Alternatively, you might want to use the BUFSIZ macro, which is provided by the <cstdio> header.

Discussion

  • sniffer

    sniffer - 2012-12-26

    I completely agree with Jakub. Just stumbled upon this one.

     
  • Arthur Barrett

    Arthur Barrett - 2018-12-10

    another vote

     

Log in to post a comment.

MongoDB Logo MongoDB