Menu
▾
▴
[Lib2geom-devel] [ 1833272 ] Compose hits assertion
|
From: <J.B...@ew...> - 2007-11-16 19:05:29
|
Please have a look at the bugreport I filed : http://sourceforge.net/tracker/index.php?func=3Ddetail&aid=3D1833272&grou= p_i d=3D167845&atid=3D844560 The assertion-checks are good, what I don't like as much is that Inkscape will crash when such an assertion is hit :-( I'd rather have an exception that I can catch and react upon! (sorry for mentioning this again, please reconsider!) Now Inkscape's pattern-along-path is crash-buggy, which it should not be. Inkscape already catches 2geom exceptions, and then just terminates LPE calculation. Then the user can fix the error, without having lost an hour of work. :-) Cheers, Johan > -----Original Message----- > From: lib...@li...=20 > [mailto:lib...@li...] On=20 > Behalf Of mgsloan > Sent: donderdag 26 juli 2007 23:33 > To: Pajarico > Cc: Lib...@li... > Subject: Re: [Lib2geom-devel] Warnings compiling lib2geom SVN >=20 > Alright, I've fixed it again. The reason for these errors is=20 > that min/max only work when the types of both sides are the=20 > same. I guess your compiler is just a bit more of a stickler=20 > - ours appear to coerce. Anyway, it's definitely good to get=20 > these fixed. Could you fix them yourself and send a patch? =20 > Just look at the type signature given in the error (the=20 > warnings don't matter), and add a conversion operator in the=20 > code as required. For example, the most recent one was=20 > max(unsigned int, long unsigned int), so I added (unsigned)=20 > to the beginning of the second operand. >=20 > Thanks, > Michael Sloan >=20 > On 7/26/07, Pajarico <paj...@gm...> wrote: > > Ok, now I'm getting this: > > > > lxuser@localhost ~/compilation/lib2geom $ make [ 3%] Generating=20 > > svg_path_parser.cpp with ragel Scanning dependencies of=20 > target 2geom [ =20 > > 7%] Building CXX object src/CMakeFiles/2geom.dir/svg-path.o > > /home/lxuser/compilation/lib2geom/src/svg-path.h:39:=20 > warning: 'class=20 > > Geom::SVGPathSink' has virtual functions but non-virtual destructor > > /home/lxuser/compilation/lib2geom/src/svg-path.h: In=20 > instantiation of=20 > >=20 > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Pa > > th, > > std::allocator<Geom::Path> > > >': > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: =20 > instantiated from here > > /home/lxuser/compilation/lib2geom/src/svg-path.h:54:=20 > warning: 'class=20 > >=20 > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Pat > > h, std::allocator<Geom::Path> > > >' has virtual functions but=20 > > non-virtual destructor > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106:=20 > warning: 'class=20 > > Geom::PathBuilder' has virtual functions but non-virtual=20 > destructor [=20 > > 11%] Building CXX object src/CMakeFiles/2geom.dir/svg-path-parser.o > > /home/lxuser/compilation/lib2geom/src/svg-path.h:39:=20 > warning: 'class=20 > > Geom::SVGPathSink' has virtual functions but non-virtual destructor > > /home/lxuser/compilation/lib2geom/src/svg-path.h: In=20 > instantiation of=20 > >=20 > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Pa > > th, > > std::allocator<Geom::Path> > > >': > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: =20 > instantiated from here > > /home/lxuser/compilation/lib2geom/src/svg-path.h:54:=20 > warning: 'class=20 > >=20 > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Pat > > h, std::allocator<Geom::Path> > > >' has virtual functions but=20 > > non-virtual destructor > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106:=20 > warning: 'class=20 > > Geom::PathBuilder' has virtual functions but non-virtual=20 > destructor [=20 > > 14%] Building CXX object src/CMakeFiles/2geom.dir/path.o [ 18%]=20 > > Building CXX object src/CMakeFiles/2geom.dir/poly.o > > /home/lxuser/compilation/lib2geom/src/poly.h: In member=20 > function 'Poly=20 > > Poly::shifted(unsigned int) const': > > /home/lxuser/compilation/lib2geom/src/poly.h:98: error: no matching=20 > > function for call to 'max(unsigned int, long unsigned int)' > > make[2]: *** [src/CMakeFiles/2geom.dir/poly.o] Error 1 > > make[1]: *** [src/CMakeFiles/2geom.dir/all] Error 2 > > make: *** [all] Error 2 > > > > 2007/7/26, mgsloan <mg...@gm...>: > > > I think the problem is that they don't have the same=20 > type. Probably=20 > > > our compilers figure out it needs to be cast to unsigned. I've=20 > > > attempted to fix it in svn, and reverted some of my old changes. > > > > > > Hope it works, > > > Michael Sloan > > > > > > On 7/24/07, Pajarico <paj...@gm...> wrote: > > > > First, thanks for your attention. Unfortunately I get the same=20 > > > > error (the only difference is that 'min' has been replaced by=20 > > > > 'Min'). I did a 'make clean' beforehand. > > > > > > > > About compiler/libs incompatibility, care to elaborate?=20 > Which libs=20 > > > > could be guilty? > > > > > > > > > > > > > The issue is the error on min. The warnings are fine. > > > > > > > > > > This is likely due to some sort of compiler/libs=20 > > > > > incompatibility, though your list looks fine. This=20 > is probably=20 > > > > > why we used to have custom min/max. Anyway, I've re-added=20 > > > > > custom Min/Max to svn. Might as well, as it might=20 > help with compatibility in the future. > > > > > > > > > > Hope that fixes it, > > > > > Michael Sloan > > > > > > > > > > On 7/22/07, Pajarico <paj...@gm...> wrote: > > > > > > Hi, I get this error while compiling SVN, 0.1 also=20 > does this: > > > > > > > > > > > > lxuser@localhost ~/compilation/lib2geom $ make [ 3%]=20 > > > > > > Generating svg_path_parser.cpp with ragel Scanning=20 > > > > > > dependencies of target 2geom [ 7%] Building CXX object=20 > > > > > > src/CMakeFiles/2geom.dir/svg-path.o > > > > > > /home/lxuser/compilation/lib2geom/src/sbasis.h: In function=20 > > > > > > 'Geom::SBasis Geom::truncate(const Geom::SBasis&,=20 > unsigned int)': > > > > > > /home/lxuser/compilation/lib2geom/src/sbasis.h:215:=20 > error: no=20 > > > > > > matching function for call to 'min(unsigned int&, size_t)' > > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h:=20 > At global scope: > > > > > >=20 > /home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning:=20 > > > > > > 'class Geom::SVGPathSink' has virtual functions but=20 > > > > > > non-virtual destructor > > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h: In=20 > > > > > > instantiation of=20 > > > > > >=20 > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector< > > > > > > Geom::Path, std::allocator<Geom::Path> > > >': > > > > > >=20 > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: =20 > instantiated from here > > > > > >=20 > /home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning:=20 > > > > > > 'class=20 > > > > > >=20 > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<G > > > > > > eom::Path, std::allocator<Geom::Path> > > >' has virtual=20 > > > > > > functions but non-virtual destructor > > > > > >=20 > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning:=20 > > > > > > 'class Geom::PathBuilder' has virtual functions but=20 > > > > > > non-virtual destructor > > > > > > make[2]: *** [src/CMakeFiles/2geom.dir/svg-path.o] Error 1 > > > > > > make[1]: *** [src/CMakeFiles/2geom.dir/all] Error 2 > > > > > > make: *** [all] Error 2 > > > > > > > > > > > > > > > > > > This is with: > > > > > > - amd64 > > > > > > - Gentoo Linux 2.6.20-r7 > > > > > > - gcc-4.1.2 > > > > > > - ragel-5.20 > > > > > > - cmake-2.4 > > > > > > > > > > > > Cheers. > > > > > > > > > > > >=20 > -------------------------------------------------------------- > > > > > > ----------- This SF.net email is sponsored by: Splunk Inc. > > > > > > Still grepping through log files to find problems? Stop. > > > > > > Now Search log events and configuration files using=20 > AJAX and a browser. > > > > > > Download your FREE copy of Splunk now >> =20 > > > > > > http://get.splunk.com/=20 > > > > > > _______________________________________________ > > > > > > Lib2geom-devel mailing list > > > > > > Lib...@li... > > > > > > https://lists.sourceforge.net/lists/listinfo/lib2geom-devel > > > > > > > > > > > > > > > > > > > > >=20 > -------------------------------------------------------------- > ----------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and=20 > a browser. > Download your FREE copy of Splunk now >> =20 > http://get.splunk.com/ _______________________________________________ > Lib2geom-devel mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/lib2geom-devel >=20 |
