Re: [Lib2geom-devel] Warnings compiling lib2geom SVN

[Pajarico <paj...@gm...>]

Thanks for the fixes. Now I can compile it fine (althought I don't
know if it works because I'm testing with inkscape_liveeffects branch,
which doesn't compile right now). However I get these warnings; I
don't know if they are of any help:

[  3%] Generating svg_path_parser.cpp with ragel
Scanning dependencies of target 2geom
[  7%] Building CXX object src/CMakeFiles/2geom.dir/svg-path.o
/home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning: 'class
Geom::SVGPathSink' has virtual functions but non-virtual destructor
/home/lxuser/compilation/lib2geom/src/svg-path.h: In instantiation of
'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
std::allocator<Geom::Path> > > >':
/home/lxuser/compilation/lib2geom/src/svg-path.h:106:   instantiated from here
/home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning: 'class
Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
std::allocator<Geom::Path> > > >' has virtual functions but
non-virtual destructor
/home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning: 'class
Geom::PathBuilder' has virtual functions but non-virtual destructor
[ 10%] Building CXX object src/CMakeFiles/2geom.dir/svg-path-parser.o
/home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning: 'class
Geom::SVGPathSink' has virtual functions but non-virtual destructor
/home/lxuser/compilation/lib2geom/src/svg-path.h: In instantiation of
'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
std::allocator<Geom::Path> > > >':
/home/lxuser/compilation/lib2geom/src/svg-path.h:106:   instantiated from here
/home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning: 'class
Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
std::allocator<Geom::Path> > > >' has virtual functions but
non-virtual destructor
/home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning: 'class
Geom::PathBuilder' has virtual functions but non-virtual destructor
[ 14%] Building CXX object src/CMakeFiles/2geom.dir/path.o
[ 17%] Building CXX object src/CMakeFiles/2geom.dir/path-intersection.o
[ 21%] Building CXX object src/CMakeFiles/2geom.dir/poly.o
[ 25%] Building CXX object src/CMakeFiles/2geom.dir/poly-dk-solve.o
[ 28%] Building CXX object src/CMakeFiles/2geom.dir/poly-laguerre-solve.o
/home/lxuser/compilation/lib2geom/src/poly-laguerre-solve.cpp: In
function 'cdouble laguerre_internal_complex(const Poly&, double,
double, bool&)':
/home/lxuser/compilation/lib2geom/src/poly-laguerre-solve.cpp:15:
warning: unused variable 'shuffle'
/home/lxuser/compilation/lib2geom/src/poly-laguerre-solve.cpp: In
function 'std::vector<double, std::allocator<double> >
laguerre_real_interval(const Poly&, double, double, double)':
/home/lxuser/compilation/lib2geom/src/poly-laguerre-solve.cpp:136:
warning: control reaches end of non-void function
[ 32%] Building CXX object src/CMakeFiles/2geom.dir/quadtree.o
[ 35%] Building CXX object src/CMakeFiles/2geom.dir/matrix.o
[ 39%] Building CXX object src/CMakeFiles/2geom.dir/transforms.o
[ 42%] Building CXX object src/CMakeFiles/2geom.dir/point.o
[ 46%] Building CXX object src/CMakeFiles/2geom.dir/d2-sbasis.o
[ 50%] Building CXX object src/CMakeFiles/2geom.dir/piecewise.o
[ 53%] Building CXX object src/CMakeFiles/2geom.dir/sbasis.o
[ 57%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-2d.o
[ 60%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-geometric.o
[ 64%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-math.o
[ 67%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-poly.o
[ 71%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-roots.o
[ 75%] Building CXX object src/CMakeFiles/2geom.dir/sbasis-to-bezier.o
[ 78%] Building CXX object src/CMakeFiles/2geom.dir/basic-intersection.o
[ 82%] Building CXX object src/CMakeFiles/2geom.dir/geom.o
[ 85%] Building CXX object src/CMakeFiles/2geom.dir/bezier-utils.o
[ 89%] Building CXX object src/CMakeFiles/2geom.dir/conjugate_gradient.o
/home/lxuser/compilation/lib2geom/src/conjugate_gradient.cpp:58:
warning: 'double Linfty(const std::valarray<double>&)' defined but not
used
[ 92%] Building CXX object src/CMakeFiles/2geom.dir/convex-cover.o
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In member
function 'void Geom::ConvexHull::graham_scan()':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:117: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In function
'std::pair<std::map<int, int, std::less<int>,
std::allocator<std::pair<const int, int> > >, std::map<int, int,
std::less<int>, std::allocator<std::pair<const int, int> > > >
Geom::bridges(Geom::ConvexHull, Geom::ConvexHull)':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:295: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:296: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In function
'Geom::ConvexHull Geom::sweepline_intersection(const
Geom::ConvexHull&, const Geom::ConvexHull&)':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:342: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:346: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:351: warning:
unused variable 'sweep_y'
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In function
'Geom::ConvexHull Geom::intersection(Geom::ConvexHull,
Geom::ConvexHull)':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:362: warning:
unused variable 'ai'
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:362: warning:
unused variable 'bi'
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:363: warning:
unused variable 'aj'
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:364: warning:
unused variable 'bj'
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In function
'Geom::ConvexHull Geom::merge(Geom::ConvexHull, Geom::ConvexHull)':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:391: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:399: warning:
comparison between signed and unsigned integer expressions
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In function
'Geom::ConvexHull Geom::sweepline_intersection(const
Geom::ConvexHull&, const Geom::ConvexHull&)':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:353: warning:
control reaches end of non-void function
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp: In member
function 'bool Geom::ConvexHull::no_colinear_points() const':
/home/lxuser/compilation/lib2geom/src/convex-cover.cpp:268: warning:
control reaches end of non-void function
[ 96%] Building CXX object src/CMakeFiles/2geom.dir/solve-bezier-one-d.o
[100%] Building CXX object src/CMakeFiles/2geom.dir/solve-bezier-parametric.o
Linking CXX static library lib2geom.a
[100%] Built target 2geom


2007/7/26, mgsloan <mg...@gm...>:
> Alright, I've fixed it again.  The reason for these errors is that
> min/max only work when the types of both sides are the same.  I guess
> your compiler is just a bit more of a stickler - ours appear to
> coerce.  Anyway, it's definitely good to get these fixed.  Could you
> fix them yourself and send a patch?  Just look at the type signature
> given in the error (the warnings don't matter), and add a conversion
> operator in the code as required.  For example, the most recent one
> was max(unsigned int, long unsigned int), so I added (unsigned) to the
> beginning of the second operand.
>
> Thanks,
> Michael Sloan
>
> On 7/26/07, Pajarico <paj...@gm...> wrote:
> > Ok, now I'm getting this:
> >
> > lxuser@localhost ~/compilation/lib2geom $ make
> > [  3%] Generating svg_path_parser.cpp with ragel
> > Scanning dependencies of target 2geom
> > [  7%] Building CXX object src/CMakeFiles/2geom.dir/svg-path.o
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning: 'class
> > Geom::SVGPathSink' has virtual functions but non-virtual destructor
> > /home/lxuser/compilation/lib2geom/src/svg-path.h: In instantiation of
> > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > std::allocator<Geom::Path> > > >':
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:106:   instantiated from here
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning: 'class
> > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > std::allocator<Geom::Path> > > >' has virtual functions but
> > non-virtual destructor
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning: 'class
> > Geom::PathBuilder' has virtual functions but non-virtual destructor
> > [ 11%] Building CXX object src/CMakeFiles/2geom.dir/svg-path-parser.o
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning: 'class
> > Geom::SVGPathSink' has virtual functions but non-virtual destructor
> > /home/lxuser/compilation/lib2geom/src/svg-path.h: In instantiation of
> > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > std::allocator<Geom::Path> > > >':
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:106:   instantiated from here
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning: 'class
> > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > std::allocator<Geom::Path> > > >' has virtual functions but
> > non-virtual destructor
> > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning: 'class
> > Geom::PathBuilder' has virtual functions but non-virtual destructor
> > [ 14%] Building CXX object src/CMakeFiles/2geom.dir/path.o
> > [ 18%] Building CXX object src/CMakeFiles/2geom.dir/poly.o
> > /home/lxuser/compilation/lib2geom/src/poly.h: In member function 'Poly
> > Poly::shifted(unsigned int) const':
> > /home/lxuser/compilation/lib2geom/src/poly.h:98: error: no matching
> > function for call to 'max(unsigned int, long unsigned int)'
> > make[2]: *** [src/CMakeFiles/2geom.dir/poly.o] Error 1
> > make[1]: *** [src/CMakeFiles/2geom.dir/all] Error 2
> > make: *** [all] Error 2
> >
> > 2007/7/26, mgsloan <mg...@gm...>:
> > > I think the problem is that they don't have the same type.  Probably
> > > our compilers figure out it needs to be cast to unsigned.  I've
> > > attempted to fix it in svn, and reverted some of my old changes.
> > >
> > > Hope it works,
> > > Michael Sloan
> > >
> > > On 7/24/07, Pajarico <paj...@gm...> wrote:
> > > > First, thanks for your attention. Unfortunately I get the same error
> > > > (the only difference is that 'min' has been replaced by 'Min'). I did
> > > > a 'make clean' beforehand.
> > > >
> > > > About compiler/libs incompatibility, care to elaborate? Which libs
> > > > could be guilty?
> > > >
> > > >
> > > > > The issue is the error on min.  The warnings are fine.
> > > > >
> > > > > This is likely due to some sort of compiler/libs incompatibility,
> > > > > though your list looks fine.  This is probably why we used to have
> > > > > custom min/max.  Anyway, I've re-added custom Min/Max to svn.  Might
> > > > > as well, as it might help with compatibility in the future.
> > > > >
> > > > > Hope that fixes it,
> > > > > Michael Sloan
> > > > >
> > > > > On 7/22/07, Pajarico <paj...@gm...> wrote:
> > > > > > Hi, I get this error while compiling SVN, 0.1 also does this:
> > > > > >
> > > > > > lxuser@localhost ~/compilation/lib2geom $ make
> > > > > > [  3%] Generating svg_path_parser.cpp with ragel
> > > > > > Scanning dependencies of target 2geom
> > > > > > [  7%] Building CXX object src/CMakeFiles/2geom.dir/svg-path.o
> > > > > > /home/lxuser/compilation/lib2geom/src/sbasis.h: In function
> > > > > > 'Geom::SBasis Geom::truncate(const Geom::SBasis&, unsigned int)':
> > > > > > /home/lxuser/compilation/lib2geom/src/sbasis.h:215: error: no matching
> > > > > > function for call to 'min(unsigned int&, size_t)'
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h: At global scope:
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h:39: warning: 'class
> > > > > > Geom::SVGPathSink' has virtual functions but non-virtual destructor
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h: In instantiation of
> > > > > > 'Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > > > > > std::allocator<Geom::Path> > > >':
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106:   instantiated from here
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h:54: warning: 'class
> > > > > > Geom::SVGPathGenerator<std::back_insert_iterator<std::vector<Geom::Path,
> > > > > > std::allocator<Geom::Path> > > >' has virtual functions but
> > > > > > non-virtual destructor
> > > > > > /home/lxuser/compilation/lib2geom/src/svg-path.h:106: warning: 'class
> > > > > > Geom::PathBuilder' has virtual functions but non-virtual destructor
> > > > > > make[2]: *** [src/CMakeFiles/2geom.dir/svg-path.o] Error 1
> > > > > > make[1]: *** [src/CMakeFiles/2geom.dir/all] Error 2
> > > > > > make: *** [all] Error 2
> > > > > >
> > > > > >
> > > > > > This is with:
> > > > > > - amd64
> > > > > > - Gentoo Linux 2.6.20-r7
> > > > > > - gcc-4.1.2
> > > > > > - ragel-5.20
> > > > > > - cmake-2.4
> > > > > >
> > > > > > Cheers.
> > > > > >
> > > > > > -------------------------------------------------------------------------
> > > > > > This SF.net email is sponsored by: Splunk Inc.
> > > > > > Still grepping through log files to find problems?  Stop.
> > > > > > Now Search log events and configuration files using AJAX and a browser.
> > > > > > Download your FREE copy of Splunk now >>  http://get.splunk.com/
> > > > > > _______________________________________________
> > > > > > Lib2geom-devel mailing list
> > > > > > Lib...@li...
> > > > > > https://lists.sourceforge.net/lists/listinfo/lib2geom-devel
> > > > > >
> > > > >
> > > >
> > >
> >
>