Re: [Lib2geom-devel] Change to meaning of Geom::Line:versor()

[Olof B. <olo...@gm...>]

Isn't there a unit test for Line, that verifies the expected behaviour? If
that was the case, Jenkins would bug us when/if that behaviour changes.

If I would like to add such a unit test, what should I fork?




Mvh


/Olof
-----------------
3-5-åriga småttingar i närheten?
Lek & lär siffror och bokstäver via mobilen m.h.a. Alfamem till Android.
https://play.google.com/store/search?q=alfamem


On 12 February 2016 at 10:36, Tavmjong Bah <tav...@fr...> wrote:

>
> Hi,
>
> Revision r14059.2.1[1] introduced a change to the value returned by
> Geom::Line::versor(). The returned vector is no longer normalized. This
> broke code in helper/geom-pathstroke.cpp. As the definition of 'versor'
> is a unit vector[2], I believe this not a good change. Can the return
> value of versor() be restored to being a unit vector?
>
> Tav
>
>
> [1] http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/1
> 4059.2.1
> [2] https://en.wikipedia.org/wiki/Unit_vector
>
>
>
>
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
> _______________________________________________
> Lib2geom-devel mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/lib2geom-devel
>