From: Krzysztof K. <twe...@gm...> - 2015-08-13 14:41:44
|
Okay, I'll get this patched then. 2015-08-13 16:39 GMT+02:00 Alvin Penner <pe...@va...>: > Sounds like a good idea, a somewhat similar problem occurred recently in > https://bugs.launchpad.net/inkscape/+bug/1473317 > > Unfortunately, I don't know how to actually do this. My C programming skills > are limited to microprocessors that are 15 years old and still use integer > arithmetic. > > Alvin > > > At 08:50 AM 8/13/2015, Krzysztof Kosiński wrote: >> >> Instead of changing the unary minus operator, the default constructor >> for SBasis should be changed so that it creates an SBasis that is >> identically zero (i.e. contains only one Linear(0, 0)). Null values >> should not be representable in the SBasis object, and there should >> assertions everywhere verifying that there is at least one element; no >> member functions should ever remove the last Linear. >> >> Regards, Krzysztof >> >> 2015-08-13 2:11 GMT+02:00 Alvin Penner <pe...@va...>: >> > Hi, >> > this is a request for comment on a proposed fix for Bug 1482806. >> > The >> > bug is apparently caused by returning a null value when attempting to >> > take the unary negative of an sbasis which is zero. The proposed code >> > returns the original sbasis instead. Any comments on whether this is >> > acceptable? The code is fairly deeply embedded, so it may have >> > implications elsewhere. >> > >> > Alvin Penner >> > >> > >> > >> > ------------------------------------------------------------------------------ >> > _______________________________________________ >> > Lib2geom-devel mailing list >> > Lib...@li... >> > https://lists.sourceforge.net/lists/listinfo/lib2geom-devel > > |