Re: [Lib2geom-devel] Mandatory path stitching

[Johan E. <jbc...@sw...>]

On 27-3-2015 20:48, Krzysztof Kosiński wrote:
> Every method that modifies a Path has an optional argument called
> "stitching" that determines whether additional segments are added to
> make the path continuous. By default, stitching is not used. If there
> are any discontinuities, calling some of Path will cause an exception
> to be thrown, which in most cases means a crash.
>
> I want to make stitching mandatory. Since in some cases you want to be
> sure that no stitching happens in your code, there will be an extra
> boolean member variable. When set to true, it will throw an exception
> whenever you try to insert a discontinuity into the path.
>
> Is everyone OK with this idea?

I am not so sure about this.
It may not be very helpful if 2geom automatically fixes "user errors", 
leading to unexpected results. If you change the default behavior (from 
not stitching to stitching), user code will suddenly behave different 
perhaps without the user knowing (e.g. no compiler error).
How about making the _choice_ for stitching behavior mandatory?

-Johan