Re: [Lib2geom-devel] C-arrays

[Johan E. <jbc...@sw...>]

On 6-11-2013 18:23, mathog wrote:
> On 06-Nov-2013 08:39, Nathan Hurst wrote:
>
>> But that code has been used for a decade now with no evidence of
>> problems, I would be loath to change it purely for stylistic reasons.
> AKA "if it ain't broken, don't fix it".

"decade" means "five years"? ;-)
Please have a look at the version log.

> It is almost always true that that there is some new language feature
> not used in code that has been around for a while.  (For any type of
> program, and any language.)  In general it is simply a waste of effort
> modifying existing code to use new language features if doing so will
> not immediately improve the performance or stability of the code.
> Neither of which seems to be the case here.

My OP was not about "some new language feature".
If anything, it will improve the readability of the code (in my 
opinion), which may inspire someone to further improve the code, or to 
use it somewhere else in the lib. Why do you think it will not improve 
the code? (certainly for stability/maintainability there is an obvious 
gain, perhaps you missed it in my earlier mails)


> Think about it, you can put a lot of work into rewriting 2geom, and when
> all is said and done, everything calling it will get exactly the same
> results at the same speed as they do now.  So why bother?

If none of my other arguments make sense, then please make do with my last:
mental entertainment.

Cheers,
   Johan