From: Vinícius d. S. O. <vin...@gm...> - 2013-08-14 21:14:25
|
Em Qui, 2013-08-15 às 00:31 +1000, Nathan Hurst escreveu: > The code looks fine to me. Is it worth pulling the 'point to string' > iterator code out into a helper method - DRY? By "point to string...", what part of the code are you referring to? > I agree about the dynamic dispatch, if you can find a good solution to > this we should use it in multiple places. I didn't know this pattern is used in many different places. My original plan was the suggestion in the TODO comment, but now that I know this info, I could look for some viable, "embedable" and multiplatform lib. > Btw, I've added you to the admin team, feel free to commit all your > changes. Thank you, I'll start committing the changes needed to cleanly install and use lib2geom in a modern system. -- Vinícius dos Santos Oliveira https://about.me/vinipsmaker |