Re: [Lib2geom-devel] Generate SVG paths from Geom::PathVector

[Nathan H. <nj...@nj...>]

On Wed, Aug 14, 2013 at 02:31:27AM -0300, Vin?cius dos Santos Oliveira wrote:
> Em Ter, 2013-08-13 ??s 23:13 +1000, Nathan Hurst escreveu:
> 
> > I think you should be able to write something using direct string
> > concatenation in an afternoon.
> 
> 
> I made too many mistakes and took longer than expected, but code is done
> now (patch attached).
> 
> I'd appreciate if any "veteran" lib2geom developer review the code.

The code looks fine to me.  Is it worth pulling the 'point to string' iterator code out into a helper method - DRY?

I agree about the dynamic dispatch, if you can find a good solution to this we should use it in multiple places.

Btw, I've added you to the admin team, feel free to commit all your changes.

njh