Re: [Lib2geom-devel] Reflect transform

[Johan E. <jbc...@sw...>]

On 25-2-2012 20:32, Krzysztof Kosiński wrote:
> Hello
>
> I saw that a Reflect transform was added to 2geom recently. It does
> not satisfy the requirements of TransformConcept:
> 1. Reflect * Reflect != Reflect (in fact there is no multiplication
> operator at all)
> 2. There is no identity element.
>
> Transforms are intended to be subgroups of Affine. Reflections are not
> a subgroup, so they should not be represented as a transform class.
> Instead, a function called Geom::reflection should return an Affine
> that represents the requested reflection.

Ah yes, I see I was way to quick in creating a whole class out of it.

Thanks for keeping me in check!

Fixed,
   Johan