Re: [Lib2geom-devel] Bug in nearest-point?

[Nathan H. <nj...@nj...>]

On Thu, Dec 29, 2011 at 09:16:49PM +0100, Johan Engelen wrote:
> Hi Nathan,
>   Seems you have forgotten to commit "solve-bezier-convex-hull.cpp"!

I don't think it's actually used, but I've commited it.  It was an
implementation of the left bounded convex hull algorithm (which is
claimed to be more robust with multiple roots, but I did not find this
to be true, at least without using special fp rounding modes).

I also added the far more important testing.h file which would allow
you to build the newly added tests.  I'm working on complete coverage
with this testing stuff, but it's slow going given I have to modify
the code on a machine in a different city over ssh.

njh

> :)
> Ciao,
>   Johan
> 
> 
> On 19-12-2011 22:58, Johan Engelen wrote:
> >On 23-9-2011 22:59, Nathan Hurst wrote:
> >>On Fri, Sep 23, 2011 at 09:17:06PM +0200, Diederik van Lierop wrote:
> >>>Thanks Nathan for your help, that is much appreciated.
> >>>
> >>>... and of course it's always good to hear that it isn't something
> >>>trivial ;-)
> >>
> >>roots is definitely misbehaving, I improved its behaviour dramatically
> >>by deflating out roots at 0 when they are detected.  Now to generalise
> >>this approach to all roots.  That is not to say that there aren't
> >>other edge cases in things like nearest point.
> >
> >Nice that you fixed some issues in trunk Nathan!
> >Is it safe for me to update Inkscape's copy?
> >
> >Thanks,
> >    Johan
> >
> >------------------------------------------------------------------------------
> >Write once. Port to many.
> >Get the SDK and tools to simplify cross-platform app development. Create
> >new or port existing apps to sell to consumers worldwide. Explore the
> >Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
> >http://p.sf.net/sfu/intel-appdev
> >_______________________________________________
> >Lib2geom-devel mailing list
> >Lib...@li...
> >https://lists.sourceforge.net/lists/listinfo/lib2geom-devel
> >