Re: [Lib2geom-devel] Big refactoring & docs patch

[njh <nj...@nj...>]

Hi Krzysztof,

I've read through your patch, and I have very little to complain about.

-        Point D(std::cos(ea.rotation_angle()), 
std::sin(ea.rotation_angle()));
+        Point D(std::cos(ea.rotationAngle()), 
std::sin(ea.rotationAngle()));

combined with sincos suggests:

Point cossin(double angle);

or cis

rather than pair<double, double> ?



What does:
+ * It is possible to left-multiply a point by a matrix, even though 
mathematically speaking
+ * this is undefined. Division by matrices is defined as multiplication 
by their inverses. */

mean?  You can certainly multiply xA if x is a row vector.  Or are you 
referring to the fact that we consider points as both vectors from the 
origin and general vectors and thus the notion of rotation is ill defined 
on unplaced general vectors?

Otherwise, your patch is great, I'm very impressed with your effort and 
systematicnessity.  Please commit to SVN.

njh