libevent - an asynchronous event library / Please use https://github.com/libevent/libevent/pulls / #79 Windows.h inclusion not needed

#79 Windows.h inclusion not needed

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2010-08-17

Created: 2010-08-17

Creator: Anonymous

Private: No

Quoting Microsoft: The Winsock2.h header file internally includes core elements from the Windows.h header file, so there is not usually an #include line for the Windows.h

The inclusion does lead to cases where WIN32_LEAN_AND_MEAN was redefined, and a warning was generated

Discussion

Nobody/Anonymous - 2010-08-17

windows_h.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Mathewson - 2010-08-17

0001-Remove-lean_and_mean-and-windows.h-includes-they-se.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Mathewson - 2010-08-17

Looks like you left out some instances. Was that intentional? How's this updated patch?

(Also, what platform are you getting warnings on? I'm not seeing any here with msvc or mingw.)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Windows.h inclusion not needed

Group

Searches

Help

#79 Windows.h inclusion not needed

Discussion