Nick Mathewson - 2013-12-24

0001-Hold-addrinfo-in-buffer_event-in-order-to-be-able-to.patch :
-- what is the use-case here?
-- The documentation needs to explain that this is only for bufferevents which were created with bufferevent_socket_connect_hostname()
-- The new field should go in struct bufferevent_private, not bufferevent.
-- There should probably be a unit test
-- Do we support multiple invocations of the bufferevent_socket_connect_hostname() on the same bufferevent? If so we should probably have a

0002:
-- It doesn't make sense to have BEV_EVENT_RESOLVE indicate a failure. It might make more sense to have BEV_EVENT_RESOLVING to take a role like BEV_EVENT_READING and BEV_EVENT_WRITING, to indicate when an error occurred.
-- The change above would allow the error to be BEV_EVENT_RESOLVING|BEV_ERROR, so that old code which checked for only BEV_EVENT_ERROR would not break. Only under really exceptional circumstances is it okay to take changes that would break existing code.
-- Needs unit tests.

0003:
-- At a minimum, this needs documentation of when you would want to set it.