Nick Mathewson - 2012-06-01

Hm. I like this patch for 2.1, but I don't want to change the ABI or API like this in the (stable) 2.0 series. My first inclination is to apply the patch to 2.1 but leave 2.0 alone.

If we had to fix this in 2.0, I'd suggest that we allocate the callback (but disable it) when we're initializing the bufferevent, so that we don't have to do any allocations in bufferevent_setwatermark.

What do you think?