I'll be submitting this patch to you and to BrickOS (in
the hopes that at least one of you accept the patch).
The changes were pretty easy, thanks to C.P. Chan (with
his message at
http://www.geocrawler.com/lists/3/SourceForge/18544/0/10061191/
). I just threw in the right ioctl() commands and
removed some code that didn't work, and presto!
Both firmdl3 and dll have been patched, and both seem
to work great for me.
BrickOS patch versus CVS on Nov 21, 2002
Logged In: NO
My name is P.C. Chan instead.
/P.C.
Logged In: NO
From your patch:
If the tty string contains "usb", e.g. /dev/usb/lego0, we assume it is
the USB tower.
That doesn't work with serial towers that are connected through an
USB->serial adapter. Some laptops come without serial ports but with
such an adapter and the device name is /dev/usb/ttyUSB0. Your patch
would assume that this is an USB tower, but it isn't.
I think it is better to use the isatty()-check. If isatty returns false it is
probably an USB tower.