#54 initial sales invoice rewrite

None
closed
nobody
1.3 addons (2)
5
2015-09-11
2007-10-15
hunmonk
No

wasnt' able to test any of the posting functions, but the display is pretty much worked out. the patch contains some extraneous fixes i was forced to make to get my test environment to run.

i'll also include the template file.

Discussion

  • hunmonk

    hunmonk - 2007-10-15

    main patch

     
  • hunmonk

    hunmonk - 2007-10-15

    Logged In: YES
    user_id=1874164
    Originator: YES

    File Added: sales_invoice.html

     
  • hunmonk

    hunmonk - 2007-10-15

    template file

     
  • Chris Travers

    Chris Travers - 2007-10-17

    Logged In: YES
    user_id=80610
    Originator: NO

    As I understand it, the major obstacles for this specific patch are:
    1) HTML validation errors.
    2) Concern that it will break the POS sales screen
    3) Some other rendering issues due to variable differences.

    Here are my suggestions regarding division of responsibilities.
    First, as long as we are at it, there is absolutely no reason why the is.pl needs to have any HTML generation code in it. Yes, there is some shared code with the POS template but if we are going to change one, we might as well change both. From there, we are only a small distance from getting the orders, vendor invoices, etc. templatized.

    As I understand it, Seneca has resolved some of the issues with the patch but this shouldn't be entirely her responsibility. My suggestion is to have Chad address only the validation and rendering issues, while I will take on the POS screen template. (I have customers using that screen anyway.)

    Also, just as a note, I have checked and is.pl's form_header is not used by any other screens, so that is not an issue as far as I can tell (but with this code base, who knows?).

    If Chad is not open to this area, then I won;t promise I will get to this patch before freeze, but I may take on that work if time permits.

     
  • Chris Travers

    Chris Travers - 2011-05-22

    will be turned into a 1.3 addon due to missing functionality.

     
  • Chris Travers

    Chris Travers - 2011-05-22
    • labels: --> 1.3 addons
     
  • Erik Huelsmann

    Erik Huelsmann - 2015-09-11

    Closing: too long since the patch-inception.

     
  • Erik Huelsmann

    Erik Huelsmann - 2015-09-11
    • status: open --> closed
    • Group: -->
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks