#1120 Form.pm::create_links eliminates obsolete accounts, even if used by the current transaction

1.5
closed-fixed
nobody
None
1.2
5
2015-10-17
2014-04-27
No

The query in Form.pm::create_links:

$query = qq|SELECT a.accno, a.description, a.link
              FROM chart a
              JOIN account ON a.id = account.id AND NOT account.obsolete
             WHERE (link LIKE ?) OR account.tax
          ORDER BY accno|;

eliminates obsolete accounts, even if those obsolete accounts are being used by the (potentially very old) transaction being viewed.

Discussion

  • Erik Huelsmann

    Erik Huelsmann - 2014-04-27

    Must be resolved in the financial rewrite: the code doesn't have any knowledge of the current transaction (and if it does, it's too hard to understand how it would).

    Moving to 1.5 for the purpose of inclusion in the rewrite.

     
  • Erik Huelsmann

    Erik Huelsmann - 2014-04-27
    • Group: 1.4 --> 1.5
     
  • Chris Travers

    Chris Travers - 2015-10-17

    create_links may work where there is a form->id so we can use that. I will fix for 1.5

     
  • Chris Travers

    Chris Travers - 2015-10-17
    • status: open --> closed-fixed
    • Version: --> 1.2
     
  • Chris Travers

    Chris Travers - 2015-10-17

    Fixed for 1.5 beta1

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks