Menu ▾ ▴

#21 Check return codes everywhere

closed-fixed
nobody
None
5
2010-03-22
2010-03-15
Markus Elfring
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "fseek" like in the function "cmsfilelength" and from "fclose" in the function "cmsIT8SaveToFile"?
http://github.com/mm2/Little-CMS/blob/master/src/cmserr.c#L52
http://github.com/mm2/Little-CMS/blob/master/src/cmscgats.c#L1685

Discussion

  • Marti Maria Saguer

    Marti Maria Saguer - 2010-03-22

    Solved in git for cmsIT8SaveToFile. Many thanks for reporting.
    For cmsfilelength, this is an special case. Shouldn't make any difference, and I think it is safer to not check the return code.

     

  • Marti Maria Saguer

    Marti Maria Saguer - 2010-03-22
    • status: open --> closed-fixed