Menu
▾
▴
1 Attachments
#18 Support for icp_a125 used in QNAP devices
This patch adds support for the icp_a125 board used in QNAP devices - I based it on the icp_a106 driver which has a different screen size but otherwise is very similar.
The data-sheet is available at http://www.mds2000.es/manuales/unknowing/lcm16a2-001/A125%20User%20Manuel%20revise%2004.pdf
Can you run LCDd on the QNAP device?
Last edit: Markus Dolze 2013-07-21
Yes, the Qnap can run LCDd.
As a matter of fact, using rawserial driver, I was able to display some text on the screen
Hi!
Just wanted to report that I applied the patch to the latest 0.5dev and it's working flawless on my QNAP TS-453 Pro.
WOW, over 2 years and nobody has taken the time to commit this?
On Mon, Jan 4, 2016 at 2:36 AM, Sam Bingner sbingner@users.sf.net wrote:
If the core developers don't have that particular piece of hardware,
it's harder to bless the code.
-ethan
Hi Sam,
I'm sorry nobody cared about your code for such a long time. Nowadays development happens at github and patches are discussed at https://github.com/lcdproc/lcdproc/pulls mostly.
However I had a quick look at your code. First of all: Is it really the best solution to add a new driver for this device? Did you explore the possibility to extend the icp_a106 driver to support this device as well?
If you think that a new driver is necessary, please be aware that new code should follow the coding style: http://lcdproc.sourceforge.net/docs/current-dev.html#code-style
and add proper documentation about your driver:
http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
HTH,
Harald
I just went with a new driver since all the other drivers seemed to be per device. I can look at if it would make sense to have an option on the a106 driver - I didn't see other drivers with options, the driver would probably need to change to something like icp_a1xx with options for specific devices right? Is that something that would be desirable? I thought I had identical style and documentation to the existing driver, but I will go over that as well, thank you.
I should then fork the GitHub code and send a pull request, right?
Sam
On Nov 3, 2016, at 9:41 AM, Harald Geyer hgeyer@users.sf.net<mailto:hgeyer@users.sf.net> wrote:
Hi Sam,
I'm sorry nobody cared about your code for such a long time. Nowadays development happens at github and patches are discussed at https://github.com/lcdproc/lcdproc/pulls mostly.
However I had a quick look at your code. First of all: Is it really the best solution to add a new driver for this device? Did you explore the possibility to extend the icp_a106 driver to support this device as well?
If you think that a new driver is necessary, please be aware that new code should follow the coding style: http://lcdproc.sourceforge.net/docs/current-dev.html#code-style
and add proper documentation about your driver:
http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
HTH,
Harald
[patches:#18]https://sourceforge.net/p/lcdproc/patches/18/ Support for icp_a125 used in QNAP devices
Status: open
Group:
Created: Mon Jul 08, 2013 03:16 AM UTC by Sam Bingner
Last Updated: Mon Jan 04, 2016 07:36 AM UTC
Owner: nobody
Attachments:
This patch adds support for the icp_a125 board used in QNAP devices - I based it on the icp_a106 driver which has a different screen size but otherwise is very similar.
The data-sheet is available at http://www.mds2000.es/manuales/unknowing/lcm16a2-001/A125%20User%20Manuel%20revise%2004.pdf
Sent from sourceforge.nethttp://sourceforge.net because you indicated interest in https://sourceforge.net/p/lcdproc/patches/18/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
Related
Patches: #18
I think it looks like it is best to be a new device as this device has keys while the a106 device does not. I have updated it to use the proper coding standard and added the documentation I'd missed the first time. I just submitted a pull request.
Sam
From: Harald Geyer [mailto:hgeyer@users.sf.net]
Sent: Thursday, November 03, 2016 9:41 AM
To: [lcdproc:patches] 18@patches.lcdproc.p.re.sf.net
Subject: [lcdproc:patches] #18 Support for icp_a125 used in QNAP devices
Hi Sam,
I'm sorry nobody cared about your code for such a long time. Nowadays development happens at github and patches are discussed at https://github.com/lcdproc/lcdproc/pulls mostly.
However I had a quick look at your code. First of all: Is it really the best solution to add a new driver for this device? Did you explore the possibility to extend the icp_a106 driver to support this device as well?
If you think that a new driver is necessary, please be aware that new code should follow the coding style: http://lcdproc.sourceforge.net/docs/current-dev.html#code-style
and add proper documentation about your driver:
http://lcdproc.sourceforge.net/docs/current-dev.html#documentation
HTH,
Harald
[patches:#18]https://sourceforge.net/p/lcdproc/patches/18/ Support for icp_a125 used in QNAP devices
Status: open
Group:
Created: Mon Jul 08, 2013 03:16 AM UTC by Sam Bingner
Last Updated: Mon Jan 04, 2016 07:36 AM UTC
Owner: nobody
Attachments:
This patch adds support for the icp_a125 board used in QNAP devices - I based it on the icp_a106 driver which has a different screen size but otherwise is very similar.
The data-sheet is available at http://www.mds2000.es/manuales/unknowing/lcm16a2-001/A125%20User%20Manuel%20revise%2004.pdf
Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/lcdproc/patches/18/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
Related
Patches: #18