Re: [lcdpd-users] Lcdp bugs?

[tom b. <to...@au...>]

> JM: Are you sure there will never be elements that consist of TL only?
Initially - yes because we don't use malformed packets.
When the code becomes more usable we will test for bad packets as well.

> JM: FIXME - make sure, that length is <= number of bytes remaining in the packet
Yes -> TODO

> JM: I don't know enough about procfs, but what happens, when there are a few
>     Elements with 64000 Bytes? Is the buffer big enough? Just looked at
>     kernel/module.c: they make sure they don't overflow any buffers!
Yes this is a bug -> TODO

> +	while ( p ) {
> +		if ( (p->timestamp.tv_sec+p->cdp_ttl) < sometime.tv_sec ) {
> +			if ( p->next ) {
> +				p = p->next;
> +				cdp_delete_neighbor( p->prev );
> JM: what is the idea behind this? why not cdp_delete_neighbor(p)?
Remeber you have to put "p" onto the next item first and then free the
item else the loop will terminate early.

Web site has been updated.

tom.
Consultant

AUSSEC    Phone: 61 4 1768 2202
339 Blaxland Rd., Ryde NSW 2112
Email: to...@au...