Re: [Lcd4linux-devel] Proper return value drv_generic_keypad_real_press callback on key release AND addition of new key constants.

[Michael R. <mi...@re...>]

Hi Andrew,

> I'm working on keypad support for the PicoLCD, and while I basically
> have it all working now, I'd just like to confirm what should be
> returned from the drv_generic_keypad_real_press callback:
> 
> Should I return WIDGET_KEY_RELEASED *plus* the constant of the key being
> released, or should I return WIDGET_KEY_RELEASED all on it's own?
Whil looking at the other drivers that support keypads, I think you 
should add WIDGET_KEY_RELEASED to the keycode.

> PS.  This keypad device supports more keys than are found in
> widget_keypad.c/.h.  I propose adding:
> 
> WIDGET_KEY_F1
> WIDGET_KEY_F2
> WIDGET_KEY_F3
> WIDGET_KEY_F4
> WIDGET_KEY_F5
> WIDGET_KEY_PLUS
> WIDGET_KEY_MINUS

Feel free to do so, patches are welcome. Thanks in advance!

OTOH,  personaly I'm not very happy with the current design of keypad 
handling. These hardcoded key codes may be a neverending story.... If 
you or anybode else has a better idea, please stand up!


bye, Michael

-- 
Michael Reinelt <mi...@re...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781