Re: [Lcd4linux-devel] [PATCH] Memory issues in plugin_mpd.c

[Michael R. <re...@eu...>]

Hi Robert,

>> The attached patch against r789 in the 0.10.1 branch should fix the issues.
> 
> I just experienced another crash when the mpd side closes the connection
> and the error handling code does some null pointer dereferences.
> I revised the patch to gracefully handle losing connections. It still
> prints a lot of errors, but the screen will end up blank after a minute
>  and when mpd comes back up, it works again.

committed to trunk. Thanks a lot!

What I've seen is that this plugin uses fprintf (STDERR, "blah") to 
report errors. These messages will silently disappear when running as a 
daemon. One really should use the error(), info() and debug() functions 
lcd4linux provides...


bye, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781