From: Hans de G. <hde...@re...> - 2013-05-14 10:21:10
|
Hi, On 05/14/2013 11:05 AM, sup...@wo... wrote: > Hi, > > I'm a maintainer of dpf-ax, the tools for hacking AX206 Digital Photo Frames. > > I've noticed some problems with the current DPF-driver for lcd4linux: > > 1. Does not compile with recent dpf-ax library. > 2. Property "Backlight" supports only on/off instead of values from 0..7. > 3. No support for the "Orientation" property. > 4. *VERY* cumbersome to get this to work because you have to get & compile dpf-ax's library separately, rename the header file *AND* copy the library/header to a special location (which is documented nowhere.) :-( > > There is a patch by Ondrej Wisniewski on the mailing list that fixes point 1 and 2. Thx Ondrej! > Point 3 is also fixed by Ondrej - but I dropped support for this property in the latest dpf-ax version. :-o > > I'm currently thinking about re-writing the driver for lcd4linux to fix all these issues. > To address point 1 and 4 I would like to include all dpf-access routines into the driver. So no more need for external headers/libraries - and no more problems. :-) > Point 2 ist already fixed by Ondrej and point 3 I'm planning to re-implement in software. > It would be the cleanest approach to split the driver in 3 files, e.g.: drv_dpf.c, drv_dpflib.c and drv_dpflib.h. > > So my question: > Is it possible / allowed / welcome for a driver to have more than one file? As far as I can see all current drivers have only one file (drv_XXXX.c.) I'm afraid I cannot answer your question, since I'm not really a lcd4linux dev, but as someone packaging lcd4linux for Fedora, and following this list for quite a while now, I can tell you that the lcd4linux project is not really actively maintained atm. I think it is great that you want to improve support for the axp dpf-s, I say go for it! I'll surely happily add the patches to the Fedora packages, even better would be if someone (maybe you) would revive the lcd4linux project, if you're interesting try to see if you can reach the original admins, and if they want to make you an admin for the sf project, then: 1) cleanup the axp driver 2) look at all the patches which have been posted on the list / are used by distros and add them 3) prepare a new release 4) put a tarbal of this release on the downloads part of the sf project 5) ??? 6) profit ! :) Regards, Hans |