From: Mattia Jona-L. <mat...@gm...> - 2011-12-21 13:04:09
|
Hi Michael, this is my patch to solve all the header related issues. If you agree I will commit these changes right away. Best, Mattia On Wed, Dec 21, 2011 at 12:20 PM, Mattia Jona-Lasinio <mat...@gm...> wrote: > Hello Michael, > > On Wed, Dec 21, 2011 at 9:12 AM, Michael Reinelt <mi...@re...> wrote: >> Hello Mattia, >> >> >>> I managed to turn lcd4linux into lcd4mac ;) on an old mac powerbook G4 >>> with powerPC processor and OS X 10.5.8 (the latest supported OS X >>> release for this processor architecture). >> >> >> Cool! >> >> >>> I compiled the X11 driver only but I included all the plugins >>> excluding the following: >>> >>> huawei: the flag IUCLC is used in one of the functions and it is >>> absent in the OS X termios flags >> >> >> I have no idea about this plugin (I don't use it) > > Yep, me neither. I have no idea about the huawei stuff. > > >>> i2c_sensors: PATH_MAX is defined in sys/syslimits.h; by including this >>> header everything is fine >> >> could this be fine on linux, too? in this case we could fix it globally. >> Could you provide a patch? > > sure! On Linux we have PATH_MAX defined in linux/limits.h but we don't > include it directly as it is automatically included by other headers. > >> >> >>> proc_stat: OS_X doesn't have a proc filesystem so this plugin does not >>> apply >> >> Is there a (simnple) way to exclude this plugin on mac somehow in the >> autoconf toolchain? > > yes, I'm not very familiar with all the autoconf stuff but it should > be feasible. > A more important question is how do we gather system information on OS X > if we don't have a proc filesystem to parse? > > >>> The libtool works a bit differently so you will have to link by hand. >>> Also depending on your installation the libiconv may differ. You may >>> want to specify the library full path when linking. >> >> >> Well, that does not sound too good to me... I always thought that's why we >> use all this autoconf stuff? > > I just linked to check if the binary ran or not. It is surely possible > to make it work with the libtool chain. > >>> I also spotted an error in timer.h This header must include the system >>> header time.h or the struct timespec is undefined. >>> Presently time.h is included in timer.c. >> >> >> Again, if this change is fine for linux, too, I want to apply it globally. > > This has nothing to do with OS X. It's a real programming error. > Headers must be self contained and should compile also on their own. > Presently timer.h compiles with a BIG warning concerning the undefined > struct timespec. With the inclusion of time.h everything is fine. > >> >> >> merry christmas to everyone! >> > > merry christmas to you all! > >> >> >> regards, michael >> >> >> -- >> Michael Reinelt <mi...@re...> >> http://home.pages.at/reinelt >> GPG-Key 0xDF13BA50 >> ICQ #288386781 |