Re: [Lcd4linux-devel] patch for G15 keyboard driver

[Michael R. <re...@eu...>]

Hi Anton,

> There is a patch for G15 driver (CVS) which is

Thanks a lot for your contribution! Patch has been applied and checked in.

> 1) fix three bugs in the code which were reason for segfaults(arrays
> boundaries)
Great! Benjamin, does this fix your problems?

> 2) add support for extra keys on keyboard (G1-G18, M1-M3,MR and 5 extra
> keys above multimedia keys, I call them L0-L4). It requires "uinput" to
> be switched on in kernel (if you don't want support for keys - just
> comment out "UInput" parameter in config file). BTW,
> "lcd4linux.conf.sample" is also patched to include device definition for
> G15.

Now this sounds like a great idea!

Q: are there any prerequisites for using uinput? Kernel version? We
should add some checks to configure, I'm afraid....

I don't know anything about the linux's uinput layer, but would it be
possible to use this stuff for all other displays with keys, too?
There's already a generic key handler in lcd4linux, which does nothing
at the moment but emit a debug message "key xy pressed". Should be easy
to integrate the passing to uinput....

on the other hand, is it possible to "get" generic keypresses from
uinput, too? this way, lcd4linux would benefit from other keys (probably
some unused keys from your keyboard, joystick, ..)

Any input would be greatly appreciated!


> Also here is some (ugly?) patch for plugin_exec, which force all child
> processes to be killed when main process is terminated.
Thanks again. I know of this problem for months, but couldn't find the
time to hunt it. I moved your signal() to a seperate function
'thread_destroy()', which is at least a bit less ugly :-)


Thanks again, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781