Re: [Lcd4linux-devel] [patch] adds keypad support for Crystalfontz 635

[Till H. <ti...@ha...>]

Hi,

On Tuesday 21 February 2006 07:10, Michael Reinelt wrote:
> I already committed your patch to CVS. I cannot test it at the moment,
> because I'd have to dig out a display with keys...
You'll soon get one in the mail ... i have just added keypad support to the
LCD2USB driver.

But i have a very stupid question: What is this good for? Ok, i can increment
and decrement values, but is there some useful real life example?

Two more things i notices:
- i accidentally put the "Keypad1 'keyup'" line in the display part inside my
 Row1 statement. This didn't work, but i didn't get a warning or error 
- why does the driver use two stages? first feed some device dependant
  data into the keypad driver and then have a callback that interprets this
  into some keypad specific values? Why don't we just return values
  the driver expects in the first place?
- What is the purpose of the KEYPADSIZE value? (BTW: A coding style
  question: Why are these variables upper case? Maybe they were constants
  once, but upper case variables are quite confusing ...)

Anyway: I love to see lcd4linux react on my buttons :-)

Ciao,
  Till

-- 
Dr.Ing. Till Harbaum <ti...@ha...>
http://www.harbaum.org/till