Re: [Lcd4linux-devel] Re: lcd4linux Noritake GUI128X32-311 - I got it working !

[Michael R. <re...@eu...>]

Hi Julien,

are you subscribed to lcd4linux-devel?

>>Do you think it would make sense to call the driver "Noritake" and give
>>it a "Model" called "GU311"? So other models could follow, and the file
>>would be called "drv_Noritake.c

> Okay ! Lets'go for that solution. 
> I will send you a drv_Noritake.c file shorlty.
> (I'm glad I did not make the commit !)
Got it, looks fine, checkd it into CVS.

Just a few comments on the driver:

- includeing linux/parport.h sould be removed. All parport stuff should
be handled by the generic parport driver. I saw that you need some
status lines. I will add some wire_status() calls to the parport driver.

- you should not use hardwire_*. This is for displays which will
*always* be wired the same way (i.e. internal devices which are
connected directly to the motherboard).

- you should store your "Models" in a array. Have a look at
drv_Cwlinux.c for an example (but you can modify the struct MODEL to
fulfill your needs)

> Thing is, the Noritake company have a lot of displays, and not all of
> them uses this protocol. Actually, this display is the only one I know
> from Noritake to use that protocol (hitachi microcontroler)
> So, If we add another display later, the protocol will likely be
> completely different, and so we will need to add other functions to this
> file, not at all related to this display. 
Thats no problem, this is the case with other displays, too (Cwlinux,
MatrixOrbital, CrystalFontz)


bye, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781