Re: [Lcd4linux-devel] My first mail, my first plugin, my fisrt SEGFAULT

[Xavier V. <xav...@fr...>]

Hello list, Buenos dias Javier :)

> Please send comments,feedback and corrections.
I've read the code of the plugin and I have one suggestion : I think the
plugin will be mostly used with a single MySQL server.
Maybe the user can set his server, user and pass once in the Variables,
and then call the mySQLquery() with only two arguments. There's a big
argument for this :
Using one persistent connection to the server will use less CPU and will
keep the plugin faster. Connecting to the server and disconnecting at
each refresh loop isn't clever and will make it lag.

I propose you to connect to the server in plugin_mysql_init and don't
forget to disconnect in plugin_mysql_quit. Maybe you should introduce
some connection tracking : if the connection is lost (bad link,
overload, timeout), reconnect to the server.

What about this ? Jerry ? Michael ?

Adios !
-- 
Xavier VELLO <xav...@fr...>