From: Xavier V. <xav...@fr...> - 2004-02-01 09:49:13
|
Hi list. > In both functions, the code that differs is only a couple of lines (so > duplicating all the other code would not be desirable). Maybe add a if - else statement in the init to switch between the two lines for 'generic' and the two ones for the special model. We don't request there are different functions for it, but we must keep it clear ! For example your patch breaks the ppdev init for 'generic' HD like mine ! I have to use old raw handling. As it's not a special feature, don't write a function, but keep it within if() statements. > But as I said - I like the idea a lot (even if I don't share your view > that the user knows what [s]he's doing :-)) Martin, please remember we're not writing a KDE app ;) This is a daemon for 'advanced users' who know (especially for HD) what (and why) they are doing. I think the lcd4linux users population is more than half geeks (like me ;) and the others are embedded systems where people know exactly their job. bye ! -- Xavier VELLO <xav...@fr...> |