Re: [lcd4linux] CrystalFontz 635 Cancel button plus some extra functions.

[Michael R. <re...@eu...>]

Hi Michael,

sorry for the *very* late answer...

> The first was that whenever I press the Cancel button on the keypad it
> did nothing. Down, left, right and Confirm all did fine. However when I
> pressed Up I got an Up event and a Cancel event raised. After some
> investigating I discovered the offending line to be in the drv_CF_keypad
> function. The code had Cancel Key Pressed as being 7 when page 14 of
> CrystalFontz data sheet says its 6. Having looked a bit more in depth at
> this it look like the released events were never converted correctly
> either as they were 1 out. The patch attached fixes this issue.

Can someone please confirm that these keycodes are working for *all* CF
displays? I'm afraid they are not, so wi will fix one display by
breaking another one...

> file::writeline(string file, string text, int mode)
> 
> This writes the line of text to the specified file. If mode is 0 it
> appends the text, if it is 1 it overwrites the file with the text. It
> returns a blank string so is only really useful in key handlers.

looks good!

> file::exec(string command)
> 
> This function runs the command. Unlike exec it runs the command only
> once and doesn't return any output text. This makes it useful for
> controlling the system from a key handler.

I'm not sure about this one. First, I think the exec() should fork() in
every case, otherwise there may be large delays which disturb other
stuff within the lcd4linux engine (timers, ...)

Probably it would be a better idea to integrate this "one-shot exec"
into the existing exec() plugin.

What do you think?


Thanks for your contribution!


bye, Michael

-- 
Michael Reinelt <re...@eu...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781