Re: [Lcd4linux-devel] Comments on "timer.c"

[Michael R. <mi...@re...>]

Hi Martin,

> So I have changed the corresponding line in "timer.c" from
> 
>    if (timercmp(&Timers[i].when, &now, <=)) {
> 
> to
> 
>    if (!timercmp(&Timers[i].when, &now, >)) {
> 
> and committed this to SVN.

I think this is fine.

> 2) I find the function "timer_inc()" rather messy.  Why not change it to

Well, most of the mess seems to come from the fact that my mind lost the modulo function :-)

apart from that, timeradd() expands to nearly the same code than yours. For me both are ok, but if you feel mess-lesser
with your version, go for it! :-)


bye, Michael

-- 
Michael Reinelt <mi...@re...>
http://home.pages.at/reinelt
GPG-Key 0xDF13BA50
ICQ #288386781